You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/07/03 08:37:22 UTC

[GitHub] flink pull request #4245: [FLINK-7012] remove user-JAR upload when disposing...

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4245

    [FLINK-7012] remove user-JAR upload when disposing a savepoint the old way

    Inside `CliFrontend#disposeSavepoint()`, user JAR files are being uploaded to the `BlobServer` but they are actually not used (also also not cleaned up) in the job manager's handling of the `DisposeSavepoint` message.
    
    Since removing new savepoints is as simple as deleting files and old savepoints have always worked without these user JARs, we should remove the upload to be able to make the JAR file upload jobId-dependent for FLINK-6916.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7012

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4245
    
----
commit b0cee0b6d95e0ed3c9bc005dfeaf34c5cdef7604
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-06-27T10:14:08Z

    [FLINK-7012] remove user-JAR upload when disposing a savepoint the old way

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4245: [FLINK-7012] remove user-JAR upload when disposing a save...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4245
  
    Good catch @NicoK. LGTM. Failing test case is unrelated. +1 for merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4245: [FLINK-7012] remove user-JAR upload when disposing...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4245


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---