You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Glen Mazza <gr...@yahoo.com> on 2005/03/13 18:29:48 UTC
Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr PageSequenceLayoutManager.java
Oops, thanks. I've just recently switched to Eclipse
(from JEdit) and haven't been able to completely turn
them off yet.
(BTW, with Eclipse, is there a way that, even if I
*do* hit the tab character key, four spaces will be
substituted instead? There's a couple of places where
I can turn of tabbing when Eclipse is doing the
indentation, but AFAICT not when I hit the tab key
myself.)
Thanks,
Glen
--- jeremias@apache.org wrote:
> jeremias 2005/03/13 02:52:28
>
> Modified: src/java/org/apache/fop/layoutmgr
>
> PageSequenceLayoutManager.java
> Log:
> Removing illegal tab characters.
>
Re: Checkstyle
Posted by Chris Bowditch <bo...@hotmail.com>.
Jeremias Maerki wrote:
> On 13.03.2005 23:30:05 Glen Mazza wrote:
<snip/>
> I've just upgraded from 3.4.1 to 3.5 and did an import of
> checkstyle3.1.1-head which worked fine. You've probably pressed "Import
> Checkstyle Config" instead of "Import Plugin Config".
>
>
>>2.) More generally, all three checkstyle files
>>("checkstyle.cfg", "checkstyle.header", and
>>"checkstyle3.1.1-head") we have in the FOP HEAD root
>>directory don't seem to work with the new checkstyle
>>3.5 download.
>
>
> I've updated FOP for use with Checkstyle 3.5 now.
Good. Thanks for doing this. I also ran into the same issues as Glen a while ago.
>>the other lacks a
>>DTD and hence fails on validation (although the DTD
>>for 3.5 appears radically different than the 3.1.1
>>XML),
>
>
> But the Eclipse plug-in can import it. That's how I converted it to the
> new syntax. You can still generate the old syntax using the Eclipse
> plug-in.
I did look at converting the checkstyle config to 3.5 but the file formats
were radically different. Didnt realise the Eclipse plugin could do the
conversion automatically :-)
<snip/>
Chris
Re: Checkstyle (was: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr PageSequenceLayoutManager.java)
Posted by Jeremias Maerki <de...@greenmail.ch>.
On 13.03.2005 23:30:05 Glen Mazza wrote:
> --- Jeremias Maerki <de...@greenmail.ch> wrote:
> > Go to Windows/Preferences, then Java/Editor, tab
> > "Typing", the activate
> > "Insert spaces for tabs".
> >
>
> Done.
>
> > Also, get the Eclipse plug-in for Checkstyle:
> > http://eclipse-cs.sourceforge.net/
> >
>
> Done, but...
>
> > Helps you keep in line with code conventions. For
> > example, it shows you
> > any occurence of a tab character in the code base.
> > That's how I find
> > these so fast.
> >
>
> 1.) Are you defining these rules manually within
> Eclipse? I can do that, also I can get the default
> "Sun Checks" working within the IDE, but when I
> attempt to import our checkstyle3.1.1-head file it is
> failing (needs a DTD for validation).
I've just upgraded from 3.4.1 to 3.5 and did an import of
checkstyle3.1.1-head which worked fine. You've probably pressed "Import
Checkstyle Config" instead of "Import Plugin Config".
> 2.) More generally, all three checkstyle files
> ("checkstyle.cfg", "checkstyle.header", and
> "checkstyle3.1.1-head") we have in the FOP HEAD root
> directory don't seem to work with the new checkstyle
> 3.5 download.
I've updated FOP for use with Checkstyle 3.5 now.
> One of them is a .properties file (not
> an XML file that checkstyle wants),
We can remove that now. It was for Checkstyle 2.x.
> the other lacks a
> DTD and hence fails on validation (although the DTD
> for 3.5 appears radically different than the 3.1.1
> XML),
But the Eclipse plug-in can import it. That's how I converted it to the
new syntax. You can still generate the old syntax using the Eclipse
plug-in.
> and the third appears to be nothing but a copy
> of the Apache license.
That's the template for the mandatory Java header. It's a regexp file
which I just updated to reflect reality. When importing the checkstyle
config into the Eclipse plugin you will need to edit the imported
configuration manually to specify the full absolute path to the header
file. Otherwise the plugin won't find it.
> Is anyone still using these?
Yep.
> Else, I'll drop them, put them in the attic for
> someone to recreate with the new 3.5 DTD whenever
> desired. Unless I'm misunderstanding things here, I
> wouldn't want anyone else to be confused that these
> three files have any relevance to modern versions of
> Checkstyle.
I'll remove the obsolete files in a minute.
Jeremias Maerki
Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr PageSequenceLayoutManager.java
Posted by Jeremias Maerki <de...@greenmail.ch>.
Go to Windows/Preferences, then Java/Editor, tab "Typing", the activate
"Insert spaces for tabs".
Also, get the Eclipse plug-in for Checkstyle:
http://eclipse-cs.sourceforge.net/
Helps you keep in line with code conventions. For example, it shows you
any occurence of a tab character in the code base. That's how I find
these so fast.
On 13.03.2005 18:29:48 Glen Mazza wrote:
> Oops, thanks. I've just recently switched to Eclipse
> (from JEdit) and haven't been able to completely turn
> them off yet.
>
> (BTW, with Eclipse, is there a way that, even if I
> *do* hit the tab character key, four spaces will be
> substituted instead? There's a couple of places where
> I can turn of tabbing when Eclipse is doing the
> indentation, but AFAICT not when I hit the tab key
> myself.)
>
> Thanks,
> Glen
>
>
> --- jeremias@apache.org wrote:
> > jeremias 2005/03/13 02:52:28
> >
> > Modified: src/java/org/apache/fop/layoutmgr
> >
> > PageSequenceLayoutManager.java
> > Log:
> > Removing illegal tab characters.
> >
Jeremias Maerki