[GitHub] [kafka] artemlivshits commented on a diff in pull request #14370: KAFKA-15449: Verify transactional offset commits (KIP-890 part 1)

["artemlivshits (via GitHub)" <gi...@apache.org>]

artemlivshits commented on code in PR #14370:
URL: https://github.com/apache/kafka/pull/14370#discussion_r1330859068


##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1048,7 +1048,9 @@ class UnifiedLog(@volatile var logStartOffset: Long,
           if (duplicateBatch.isPresent) {
             return (updatedProducers, completedTxns.toList, Some(duplicateBatch.get()))
           }
+        }
 
+        if (origin == AppendOrigin.CLIENT || origin == AppendOrigin.COORDINATOR) {
           // Verify that if the record is transactional & the append origin is client, that we either have an ongoing transaction or verified transaction state.

Review Comment:
   Comment should probably be updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org