You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "colvinco (via GitHub)" <gi...@apache.org> on 2023/02/03 14:59:27 UTC
[GitHub] [solr] colvinco opened a new pull request, #1329: SOLR-9698 - Fix start/stop wait time and RMI_PORT on Windows
colvinco opened a new pull request, #1329:
URL: https://github.com/apache/solr/pull/1329
https://issues.apache.org/jira/browse/SOLR-9698
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
This is a set of fixes for the Windows solr.cmd script.
- `SOLR_STOP_WAIT` and `SOLR_START_WAIT` are now respected
- `solr stop -all` was previously overwriting the `STOP_PORT` if it wasn't specified. That meant that the first `STOP_PORT` calculated would be used when stopping the remaining nodes which would fail.
- Check if the calculated RMI port or embedded zookeeper port is > `65535` and error
The shell script already checked the RMI port, but I've added a check for the zookeeper port to it.
# Solution
For stopping I've incorporated a script that we've been using in our product for 3 or 4 years. (I see that SOLR-9698 has a patch on it with something very similar). The script uses `ping` to simulate a sleep, as `timeout` doesn't work on non-interactive shells. The total wait time is approximated, for large values it will drift slightly, tending to wait slightly _longer_ than specified.
# Tests
Manually tested
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] colvinco merged pull request #1329: SOLR-9698 - Fix start/stop wait time and RMI_PORT on Windows
Posted by "colvinco (via GitHub)" <gi...@apache.org>.
colvinco merged PR #1329:
URL: https://github.com/apache/solr/pull/1329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] colvinco commented on a diff in pull request #1329: SOLR-9698 - Fix start/stop wait time and RMI_PORT on Windows
Posted by "colvinco (via GitHub)" <gi...@apache.org>.
colvinco commented on code in PR #1329:
URL: https://github.com/apache/solr/pull/1329#discussion_r1095907702
##########
solr/bin/solr.cmd:
##########
@@ -1409,11 +1428,15 @@ IF "%FG%"=="1" (
-Djava.io.tmpdir="%SOLR_SERVER_DIR%\tmp" -jar start.jar %SOLR_JETTY_CONFIG% "%SOLR_JETTY_ADDL_CONFIG%" > "!SOLR_LOGS_DIR!\solr-%SOLR_PORT%-console.log"
echo %SOLR_PORT%>"%SOLR_TIP%"\bin\solr-%SOLR_PORT%.port
+ REM default to 30 seconds for backwards compatibility.
+ IF "%SOLR_START_WAIT%"=="" (
Review Comment:
```suggestion
IF "!SOLR_START_WAIT!"=="" (
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org