You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2018/05/26 10:53:22 UTC
[kylin] 06/08: Minor,
fix wrong method name of cube's input record size
This is an automated email from the ASF dual-hosted git repository.
liyang pushed a commit to branch sync
in repository https://gitbox.apache.org/repos/asf/kylin.git
commit 2f00b03f7e04fb5205a1ed70967b4f3b867b7fa9
Author: nichunen <ch...@kyligence.io>
AuthorDate: Fri May 4 15:18:02 2018 +0800
Minor, fix wrong method name of cube's input record size
---
core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java | 2 +-
.../java/org/apache/kylin/rest/response/CubeInstanceResponse.java | 8 ++++----
.../main/java/org/apache/kylin/rest/service/DashboardService.java | 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java b/core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
index b4f712b..bf966d4 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/CubeInstance.java
@@ -642,7 +642,7 @@ public class CubeInstance extends RootPersistentEntity implements IRealization,
}
// For JSON serialization of this attribute, use CubeInstanceResponse
- public long getInputRecordSizeMB() {
+ public long getInputRecordSizeBytes() {
long sizeRecordSize = 0L;
for (CubeSegment cubeSegment : this.getSegments(SegmentStatusEnum.READY)) {
diff --git a/server-base/src/main/java/org/apache/kylin/rest/response/CubeInstanceResponse.java b/server-base/src/main/java/org/apache/kylin/rest/response/CubeInstanceResponse.java
index 63c305f..19a5ef5 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/response/CubeInstanceResponse.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/response/CubeInstanceResponse.java
@@ -45,7 +45,7 @@ public class CubeInstanceResponse extends CubeInstance {
@JsonProperty("input_records_count")
private long inputRecordCnt;
@JsonProperty("input_records_size")
- private long inputRecordSizeMB;
+ private long inputRecordSizeBytes;
public CubeInstanceResponse(CubeInstance cube, String project) {
@@ -79,7 +79,7 @@ public class CubeInstanceResponse extends CubeInstance {
initSizeKB();
initInputRecordCount();
- initInputRecordSizeMB();
+ initInputRecordSizeBytes();
}
protected void setModel(String model) {
@@ -94,8 +94,8 @@ public class CubeInstanceResponse extends CubeInstance {
this.inputRecordCnt = super.getInputRecordCount();
}
- protected void initInputRecordSizeMB() {
- this.inputRecordSizeMB = super.getInputRecordSizeMB();
+ protected void initInputRecordSizeBytes() {
+ this.inputRecordSizeBytes = super.getInputRecordSizeBytes();
}
}
diff --git a/server-base/src/main/java/org/apache/kylin/rest/service/DashboardService.java b/server-base/src/main/java/org/apache/kylin/rest/service/DashboardService.java
index 63bc4fe..e548693 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/service/DashboardService.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/service/DashboardService.java
@@ -139,10 +139,10 @@ public class DashboardService extends BasicService {
Float maxCubeExpansion = Float.NEGATIVE_INFINITY;
cubeMetrics.increase("totalCube", totalCube.floatValue());
for (CubeInstance cubeInstance : cubeInstances) {
- if (cubeInstance.getInputRecordSizeMB() > 0) {
+ if (cubeInstance.getInputRecordSizeBytes() > 0) {
totalCubeSize += cubeInstance.getSizeKB();
- totalRecoadSize += cubeInstance.getInputRecordSizeMB();
- Float cubeExpansion = new Float(cubeInstance.getSizeKB()) * 1024 / cubeInstance.getInputRecordSizeMB();
+ totalRecoadSize += cubeInstance.getInputRecordSizeBytes();
+ Float cubeExpansion = new Float(cubeInstance.getSizeKB()) * 1024 / cubeInstance.getInputRecordSizeBytes();
if (cubeExpansion > maxCubeExpansion) {
maxCubeExpansion = cubeExpansion;
}
--
To stop receiving notification emails like this one, please contact
liyang@apache.org.