You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/03 21:56:03 UTC

[GitHub] [incubator-superset] lilykuang opened a new pull request #9981: implement secondary navigation for datasets

lilykuang opened a new pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: [WIP] feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `6.55%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   - Coverage   71.38%   64.82%   -6.56%     
   ==========================================
     Files         585      531      -54     
     Lines       30949    29533    -1416     
     Branches     3261     2886     -375     
   ==========================================
   - Hits        22094    19146    -2948     
   - Misses       8746    10212    +1466     
   - Partials      109      175      +66     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.06% <ø> (-0.02%)` | :arrow_down: |
   | #javascript | `?` | |
   | #python | `71.57% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
   | [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
   | [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
   | [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
   | ... and [201 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...256068c](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: [WIP] feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] lilykuang closed pull request #9981: feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
lilykuang closed pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   + Coverage   71.38%   71.57%   +0.18%     
   ==========================================
     Files         585      184     -401     
     Lines       30949    18155   -12794     
     Branches     3261        0    -3261     
   ==========================================
   - Hits        22094    12994    -9100     
   + Misses       8746     5161    -3585     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.57% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | | |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | | |
   | [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | | |
   | [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | | |
   | [...et-frontend/src/SqlLab/components/QueryHistory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5SGlzdG9yeS5qc3g=) | | |
   | [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | | |
   | [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | | |
   | [...nd/src/dashboard/components/ColorComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yQ29tcG9uZW50UGFuZS5qc3g=) | | |
   | [...perset-frontend/src/middleware/loggerMiddleware.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvbG9nZ2VyTWlkZGxld2FyZS5qcw==) | | |
   | ... and [390 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...380eb57](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   + Coverage   71.38%   71.50%   +0.11%     
   ==========================================
     Files         585      184     -401     
     Lines       30949    18155   -12794     
     Branches     3261        0    -3261     
   ==========================================
   - Hits        22094    12982    -9112     
   + Misses       8746     5173    -3573     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.50% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.38% <0.00%> (-0.22%)` | :arrow_down: |
   | [...rontend/src/dashboard/util/componentIsResizable.ts](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NvbXBvbmVudElzUmVzaXphYmxlLnRz) | | |
   | [superset-frontend/src/components/Select/styles.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3N0eWxlcy50c3g=) | | |
   | [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | | |
   | [...et-frontend/src/explore/controlPanels/Separator.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TZXBhcmF0b3IuanM=) | | |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | | |
   | [...c/visualizations/TimeTable/TimeTableChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGVDaGFydFBsdWdpbi5qcw==) | | |
   | [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | | |
   | ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...380eb57](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter commented on pull request #9981: [WIP] feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.20%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   - Coverage   71.38%   71.18%   -0.21%     
   ==========================================
     Files         585      184     -401     
     Lines       30949    18041   -12908     
     Branches     3261        0    -3261     
   ==========================================
   - Hits        22094    12842    -9252     
   + Misses       8746     5199    -3547     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.18% <ø> (-0.40%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
   | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
   | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
   | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `36.72% <0.00%> (-3.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
   | ... and [417 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...256068c](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   + Coverage   71.38%   71.50%   +0.11%     
   ==========================================
     Files         585      184     -401     
     Lines       30949    18155   -12794     
     Branches     3261        0    -3261     
   ==========================================
   - Hits        22094    12982    -9112     
   + Misses       8746     5173    -3573     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.50% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.38% <0.00%> (-0.22%)` | :arrow_down: |
   | [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | | |
   | [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | | |
   | [...et-frontend/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29uZmlybVN0YXR1c0NoYW5nZS50c3g=) | | |
   | [...explore/components/AdhocMetricEditPopoverTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyVGl0bGUuanN4) | | |
   | [superset-frontend/src/components/ChartIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uLmpzeA==) | | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | | |
   | [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | | |
   | ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...380eb57](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: [WIP] feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   + Coverage   71.38%   71.50%   +0.11%     
   ==========================================
     Files         585      184     -401     
     Lines       30949    18155   -12794     
     Branches     3261        0    -3261     
   ==========================================
   - Hits        22094    12982    -9112     
   + Misses       8746     5173    -3573     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.50% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.38% <0.00%> (-0.22%)` | :arrow_down: |
   | [...perset-frontend/src/components/FilterBadgeIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyQmFkZ2VJY29uLmpzeA==) | | |
   | [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UaW1lU2VyaWVzQ29sdW1uQ29udHJvbC5qc3g=) | | |
   | [...end/src/visualizations/TimeTable/transformProps.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS90cmFuc2Zvcm1Qcm9wcy5qcw==) | | |
   | [superset-frontend/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy5qc3g=) | | |
   | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | | |
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | | |
   | [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | | |
   | ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...256068c](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: [WIP] feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   + Coverage   71.38%   71.50%   +0.11%     
   ==========================================
     Files         585      184     -401     
     Lines       30949    18155   -12794     
     Branches     3261        0    -3261     
   ==========================================
   - Hits        22094    12982    -9112     
   + Misses       8746     5173    -3573     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `71.50% <ø> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.38% <0.00%> (-0.22%)` | :arrow_down: |
   | [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | | |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
   | [...et-frontend/src/messageToasts/components/Toast.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdC5qc3g=) | | |
   | [superset-frontend/src/messageToasts/propShapes.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvcHJvcFNoYXBlcy5qcw==) | | |
   | [.../src/explore/components/controls/SliderControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TbGlkZXJDb250cm9sLmpzeA==) | | |
   | [.../src/explore/components/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9GaWx0ZXJEZWZpbml0aW9uT3B0aW9uLmpzeA==) | | |
   | [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | | |
   | ... and [393 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...256068c](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9981: [WIP] feat: secondary navigation for datasets

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9981:
URL: https://github.com/apache/incubator-superset/pull/9981#issuecomment-638484608


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=h1) Report
   > Merging [#9981](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `6.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9981/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9981      +/-   ##
   ==========================================
   - Coverage   71.38%   64.50%   -6.89%     
   ==========================================
     Files         585      531      -54     
     Lines       30949    29533    -1416     
     Branches     3261     2886     -375     
   ==========================================
   - Hits        22094    19049    -3045     
   - Misses       8746    10300    +1554     
   - Partials      109      184      +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.21% <ø> (-0.88%)` | :arrow_down: |
   | #javascript | `?` | |
   | #python | `71.57% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.19%)` | :arrow_down: |
   | [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
   | [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `0.00% <0.00%> (-87.10%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `6.59% <0.00%> (-82.42%)` | :arrow_down: |
   | [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
   | ... and [203 more](https://codecov.io/gh/apache/incubator-superset/pull/9981/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=footer). Last update [dcac860...256068c](https://codecov.io/gh/apache/incubator-superset/pull/9981?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org