You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/08/02 10:05:56 UTC
[GitHub] [shardingsphere] FlyingZC opened a new issue, #27859: Support parsing openGauss ALTER sql
FlyingZC opened a new issue, #27859:
URL: https://github.com/apache/shardingsphere/issues/27859
# Background
Hi community,
ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for openGauss SQL parsing in ShardingSphere.
More details:
https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
# Task
This issue is to support more openGauss sql parse, as follows:
```sql
ALTER TEXT SEARCH CONFIGURATION joe.ngram2 RENAME TO ngram_2;
--删除类型映射。
```
```sql
ALTER TEXT SEARCH CONFIGURATION joe.ngram_2 DROP MAPPING IF EXISTS FOR multisymbol;
--删除文本搜索配置。
```
```sql
DROP TEXT SEARCH CONFIGURATION joe.ngram_2;
```
```sql
DROP TEXT SEARCH CONFIGURATION ngram3;
--删除Schema及用户joe。
```
```sql
INSERT INTO customer_t_copy (SELECT * FROM customer_t);
```
# Process
1. First confirm that this is a correct openGauss sql syntax, if not please leave a message under the issue and ignore it;
2. Compare SQL definitions in Official SQL Doc and ShardingSphere SQL Doc;
3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
4. Run mvn install the current_file_module;
5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statement XML;
7. Run SQLParserParameterizedTest to make sure no exceptions.
# Relevant Skills
1. Master JAVA language
2. Have a basic understanding of Antlr `g4` file
3. Be familiar with openGauss SQLs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing openGauss ALTER sql [shardingsphere]
Posted by "akashpambhar (via GitHub)" <gi...@apache.org>.
akashpambhar commented on issue #27859:
URL: https://github.com/apache/shardingsphere/issues/27859#issuecomment-1746126000
@strongduanmu can you please guide me on this. I'm trying to add parsing support for
> ALTER TEXT SEARCH CONFIGURATION joe.ngram2 RENAME TO ngram_2;
For that I have tried adding modifying this two files:
`test/it/parser/src/main/resources/case/ddl/alter-text-search.xml`
```
<alter-text-search sql-case-id="alter_text_search_configuration_rename2" />
```
`test/it/parser/src/main/resources/sql/supported/ddl/alter-text-search.xml`
```
<sql-case id="alter_text_search_configuration_rename2" value="ALTER TEXT SEARCH CONFIGURATION config.old_name RENAME new_name" db-types="openGauss" />
```
When I try to set incorrect SQL query above and do `mvn install` it passes all test cases successfully. Can you guide me what should I do to make sure test case work properly?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] github-actions[bot] commented on issue #27859: Support parsing openGauss ALTER sql
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27859:
URL: https://github.com/apache/shardingsphere/issues/27859#issuecomment-1703265216
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing openGauss ALTER sql [shardingsphere]
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC closed issue #27859: Support parsing openGauss ALTER sql
URL: https://github.com/apache/shardingsphere/issues/27859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing openGauss ALTER sql [shardingsphere]
Posted by "akashpambhar (via GitHub)" <gi...@apache.org>.
akashpambhar commented on issue #27859:
URL: https://github.com/apache/shardingsphere/issues/27859#issuecomment-1774129825
Hi, @strongduanmu. I tried to debug the issue but was unable to locate the changes exactly. Although, I tried looking for references but couldn't figure out. I also changed few SQL statements of different databases in different case files so that they become incorrect, but still when I ran mvn test or install, it is passing successfully. Due to that I'm kind of stuck. Would you please help me understand what am I missing out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing openGauss ALTER sql [shardingsphere]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #27859:
URL: https://github.com/apache/shardingsphere/issues/27859#issuecomment-1821603546
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing openGauss ALTER sql [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on issue #27859:
URL: https://github.com/apache/shardingsphere/issues/27859#issuecomment-1746930697
@akashpambhar It appears that we did not add SQLStatementAssert to the `alter-text-search` statement. Can you debug it and add assertion logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Support parsing openGauss ALTER sql [shardingsphere]
Posted by "akashpambhar (via GitHub)" <gi...@apache.org>.
akashpambhar commented on issue #27859:
URL: https://github.com/apache/shardingsphere/issues/27859#issuecomment-1748029945
Thank You. I'll try it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org