You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/27 00:44:11 UTC

Review Request 26106: Add updater support for disabling rollback and batched update settings.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26106/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-744 and AURORA-747
    https://issues.apache.org/jira/browse/AURORA-744
    https://issues.apache.org/jira/browse/AURORA-747


Repository: aurora


Description
-------

Add updater support for disabling rollback and batched update settings.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 5dec82aef337f42a402084f2c1a1776bb977ab56 
  src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 
  src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 
  src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 2794242e71515effdc710cb40e881baca9dc4124 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 866e6587a2deee39228ccabf89bf276cc5e44881 
  src/main/thrift/org/apache/aurora/gen/api.thrift cebd2c30dc536debbbe8a7d38d81eb5030978135 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 7e4184330bdec271ead0d700bc02c8b3470876a9 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 

Diff: https://reviews.apache.org/r/26106/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Bill Farner


Re: Review Request 26106: Add updater support for disabling rollback and batched update settings.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26106/
-----------------------------------------------------------

(Updated Sept. 27, 2014, 7:36 a.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Changes
-------

Fixed python test break.


Bugs: AURORA-744 and AURORA-747
    https://issues.apache.org/jira/browse/AURORA-744
    https://issues.apache.org/jira/browse/AURORA-747


Repository: aurora


Description
-------

Add updater support for disabling rollback and batched update settings.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 5dec82aef337f42a402084f2c1a1776bb977ab56 
  src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 
  src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 
  src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 2794242e71515effdc710cb40e881baca9dc4124 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 866e6587a2deee39228ccabf89bf276cc5e44881 
  src/main/thrift/org/apache/aurora/gen/api.thrift cebd2c30dc536debbbe8a7d38d81eb5030978135 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 7e4184330bdec271ead0d700bc02c8b3470876a9 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 
  src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9 

Diff: https://reviews.apache.org/r/26106/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Bill Farner


Re: Review Request 26106: Add updater support for disabling rollback and batched update settings.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26106/#review54754
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Sept. 26, 2014, 10:44 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26106/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 10:44 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-744 and AURORA-747
>     https://issues.apache.org/jira/browse/AURORA-744
>     https://issues.apache.org/jira/browse/AURORA-747
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add updater support for disabling rollback and batched update settings.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 5dec82aef337f42a402084f2c1a1776bb977ab56 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 
>   src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 2794242e71515effdc710cb40e881baca9dc4124 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 866e6587a2deee39228ccabf89bf276cc5e44881 
>   src/main/thrift/org/apache/aurora/gen/api.thrift cebd2c30dc536debbbe8a7d38d81eb5030978135 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 7e4184330bdec271ead0d700bc02c8b3470876a9 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 
> 
> Diff: https://reviews.apache.org/r/26106/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>