[jira] [Commented] (RANGER-995) Implement good coding practices

["rangerqa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RANGER-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302175#comment-15302175 ] 

rangerqa commented on RANGER-995:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12806378/CSRF_Implementation_In_Ranger.patch
  against master revision 5a40ad3.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-RANGER-Build/216//testReport/
Console output: https://builds.apache.org/job/PreCommit-RANGER-Build/216//console

This message is automatically generated.

> Implement good coding practices
> -------------------------------
>
>                 Key: RANGER-995
>                 URL: https://issues.apache.org/jira/browse/RANGER-995
>             Project: Ranger
>          Issue Type: Bug
>            Reporter: Velmurugan Periasamy
>            Assignee: Velmurugan Periasamy
>            Priority: Critical
>             Fix For: 0.6.0
>
>         Attachments: CSRF_Implementation_In_Ranger.patch, RANGER-995-session-fixation.patch
>
>
> Implement good practices by doing the below.
> 1] Add CSRF Filter implementation
> 2] Add session fixation protection implementation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)