You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2020/07/26 00:42:19 UTC

[skywalking] branch prom-histogram-label created (now c666692)

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a change to branch prom-histogram-label
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


      at c666692  Fix histogram labels are absent

This branch includes the following new commits:

     new c666692  Fix histogram labels are absent

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[skywalking] 01/01: Fix histogram labels are absent

Posted by ha...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch prom-histogram-label
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit c66669275619628e9f00fe78d30c15e11b70a8e2
Author: Gao Hongtao <ha...@gmail.com>
AuthorDate: Sun Jul 26 08:41:58 2020 +0800

    Fix histogram labels are absent
---
 .../skywalking/oap/server/library/util/prometheus/parser/Context.java    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/prometheus/parser/Context.java b/oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/prometheus/parser/Context.java
index ef4c4b5..d0482fe 100644
--- a/oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/prometheus/parser/Context.java
+++ b/oap-server/server-library/library-util/src/main/java/org/apache/skywalking/oap/server/library/util/prometheus/parser/Context.java
@@ -116,6 +116,7 @@ public class Context {
                 Histogram.HistogramBuilder hBuilder = Histogram.builder();
                 hBuilder.name(name).timestamp(now);
                 samples.forEach(textSample -> {
+                    hBuilder.labels(textSample.getLabels());
                     if (textSample.getName().endsWith("_count")) {
                         hBuilder.sampleCount((long) convertStringToDouble(textSample.getValue()));
                     } else if (textSample.getName().endsWith("_sum")) {