You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "bschoening (via GitHub)" <gi...@apache.org> on 2023/08/31 18:08:20 UTC

[GitHub] [cassandra] bschoening commented on a diff in pull request #2653: Cassandra 18787: Replace or remove obsolete functions and simplify cql_verison handling

bschoening commented on code in PR #2653:
URL: https://github.com/apache/cassandra/pull/2653#discussion_r1312012799


##########
pylib/cqlshlib/cqlshmain.py:
##########
@@ -277,22 +276,10 @@ def __repr__(self):
         return '<%s %s>' % (self.__class__.__name__, self.message())
 
 
-def maybe_ensure_text(val):

Review Comment:
   Since Python 3.0, all string are Unicode.  It appears left over from python 2.x.  Its used only on four command line args to "make sure user values .. are in unicode"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org