[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #2021: [flink] Allow dynamic configuration of 'continuous.discovery-interval' using hints in Flink lookup joins.

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #2021:
URL: https://github.com/apache/incubator-paimon/pull/2021#discussion_r1328522724


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/RocksDBOptions.java:
##########
@@ -55,6 +56,12 @@ public class RocksDBOptions {
                     .defaultValue(10_000L)
                     .withDescription("The maximum number of rows to store in the cache.");
 
+    public static final ConfigOption<Duration> LOOKUP_CONTINUOUS_DISCOVERY_INTERVAL =
+            key("lookup.continuous.discovery-interval")
+                    .durationType()
+                    .defaultValue(Duration.ofSeconds(10))

Review Comment:
   Can this be `noDefaultValue`, and fallback to `continuous.discovery-interval`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org