You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/13 04:11:18 UTC
[GitHub] [incubator-superset] auxten opened a new pull request #9321: Fix add chart page translation not work
auxten opened a new pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
the `chart/add` page translation not work, because of:
1. language pack not loaded before render template
2. translator in `preamble.js` only try to get language pack from node `id="app"`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321#issuecomment-657348212
Closing/reopening to see how this does with revamped CI processes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321#issuecomment-636508092
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321#issuecomment-675846084
Please rebase!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cdmikechen commented on pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
cdmikechen commented on pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321#issuecomment-675211153
@auxten sad, too...
另外想咨询下你们也在使用superset做一些本地化的工作吗？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] auxten commented on pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
auxten commented on pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321#issuecomment-676928585
> Please rebase!
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] JunlinC commented on pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
JunlinC commented on pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321#issuecomment-675693682
🏷localization
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas closed pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] auxten commented on pull request #9321: Fix add chart page translation not work
Posted by GitBox <gi...@apache.org>.
auxten commented on pull request #9321:
URL: https://github.com/apache/incubator-superset/pull/9321#issuecomment-637300986
No one would give it a look, so sad
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org