You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/01 07:24:34 UTC

[GitHub] [flink] Thesharing edited a comment on pull request #19275: [FLINK-24491][runtime] Make the job termination wait until the archiving of ExecutionGraphInfo finishes

Thesharing edited a comment on pull request #19275:
URL: https://github.com/apache/flink/pull/19275#issuecomment-1084449612


   Thank you so much for your review and suggestions, @XComp! 😄 
   
   ![Illustration](https://user-images.githubusercontent.com/6576831/161047726-613407d3-114e-4a28-a536-de2b61552576.jpg)
   
   I draw an illustration for two options. Option 1 chains the result future of archiving and the result future of resource cleanup. Option 2 makes the `handleJobManagerRunnerResult` and `jobManagerRunnerFailed` return a `CompletableFuture<CleanupJobState>`.
   
   Option 1 could parallelize two IO operations. Furthermore, if the archiving takes a long time in the worst case, the job may be terminated by users or external resource providers. In this situation, the job still get cleaned up. Therefore, I think maybe option 1 is better. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org