You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2015/11/30 06:00:24 UTC
svn commit: r1717171 -
/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java
Author: onealj
Date: Mon Nov 30 05:00:24 2015
New Revision: 1717171
URL: http://svn.apache.org/viewvc?rev=1717171&view=rev
Log:
fix testErr: createRow(1) -> createRow(0); replace assumeTrue with assertEquals for more informative test results
Modified:
poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java
Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java?rev=1717171&r1=1717170&r2=1717171&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java Mon Nov 30 05:00:24 2015
@@ -23,7 +23,6 @@ import static org.junit.Assert.assertNot
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
-import static org.junit.Assume.assumeTrue;
import java.io.IOException;
import java.util.Calendar;
@@ -154,14 +153,14 @@ public abstract class BaseTestCell {
// B1
r = s.createRow(0);
c=r.createCell(1);
- assumeTrue(0 == c.getRowIndex());
- assumeTrue(1 == c.getColumnIndex());
+ assertEquals(0, c.getRowIndex());
+ assertEquals(1, c.getColumnIndex());
c.setCellValue(true);
// C1
c=r.createCell(2);
- assumeTrue(0 == c.getRowIndex());
- assumeTrue(2 == c.getColumnIndex());
+ assertEquals(0, c.getRowIndex());
+ assertEquals(2, c.getColumnIndex());
c.setCellValue(false);
Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
@@ -169,17 +168,17 @@ public abstract class BaseTestCell {
s = wb2.getSheet("testSheet1");
r = s.getRow(0);
- assumeTrue("Row 1 should have 2 cells", 2 == r.getPhysicalNumberOfCells());
+ assertEquals("Row 1 should have 2 cells", 2, r.getPhysicalNumberOfCells());
c = r.getCell(1);
- assumeTrue(0 == c.getRowIndex());
- assumeTrue(1 == c.getColumnIndex());
+ assertEquals(0, c.getRowIndex());
+ assertEquals(1, c.getColumnIndex());
assertEquals(Cell.CELL_TYPE_BOOLEAN, c.getCellType());
assertEquals("B1 value", true, c.getBooleanCellValue());
c = r.getCell(2);
- assumeTrue(0 == c.getRowIndex());
- assumeTrue(2 == c.getColumnIndex());
+ assertEquals(0, c.getRowIndex());
+ assertEquals(2, c.getColumnIndex());
assertEquals(Cell.CELL_TYPE_BOOLEAN, c.getCellType());
assertEquals("C1 value", false, c.getBooleanCellValue());
@@ -199,16 +198,16 @@ public abstract class BaseTestCell {
Cell c;
// B1
- r = s.createRow(1);
+ r = s.createRow(0);
c=r.createCell(1);
- assumeTrue(0 == c.getRowIndex());
- assumeTrue(1 == c.getColumnIndex());
+ assertEquals(0, c.getRowIndex());
+ assertEquals(1, c.getColumnIndex());
c.setCellErrorValue(FormulaError.NULL.getCode());
// C1
c=r.createCell(2);
- assumeTrue(0 == c.getRowIndex());
- assumeTrue(2 == c.getColumnIndex());
+ assertEquals(0, c.getRowIndex());
+ assertEquals(2, c.getColumnIndex());
c.setCellErrorValue(FormulaError.DIV0.getCode());
Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
@@ -217,7 +216,7 @@ public abstract class BaseTestCell {
s = wb2.getSheet("testSheet1");
r = s.getRow(0);
- assumeTrue("Row 1 should have 2 cells", 2 == r.getPhysicalNumberOfCells());
+ assertEquals("Row 1 should have 2 cells", 2, r.getPhysicalNumberOfCells());
c = r.getCell(1);
assertEquals(Cell.CELL_TYPE_ERROR, c.getCellType());
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org