[jira] [Commented] (ZOOKEEPER-1411) Consolidate membership management, distinguish between static and dynamic configuration parameters

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619199#comment-13619199 ] 

Hadoop QA commented on ZOOKEEPER-1411:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12576430/ZOOKEEPER-1411-small-fix.patch
  against trunk revision 1462141.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1442//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1442//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1442//console

This message is automatically generated.
                
> Consolidate membership management, distinguish between static and dynamic configuration parameters
> --------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1411
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1411-small-fix.patch, ZOOKEEPER-1411-ver10.patch, ZOOKEEPER-1411-ver11.patch, ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, ZOOKEEPER-1411-ver5.patch, ZOOKEEPER-1411-ver6.patch, ZOOKEEPER-1411-ver7.patch, ZOOKEEPER-1411-ver8.patch, ZOOKEEPER-1411-ver9.patch
>
>
> Currently every server has a different static configuration file. This patch distinguishes between dynamic parameters, which are now in a separate "dynamic configuration file", and static parameters which are in the usual file. The config file points to the dynamic config file by specifying "dynamicConfigFile=...". In the first stage (this patch), all cluster membership definitions are in the dynamic config file, but in the future additional parameters may be moved to the dynamic file.
> Backward compatibility makes sure that you can still use a single config file if you'd like. Only when the config is changed (once ZK-107 is in) a dynamic file is automatically created and the necessary parameters are moved to it. 
> This patch also moves all membership parsing and management into the QuorumVerifier classes, and removes QuorumPeer.quorumPeers.
> The cluster membership is contained in QuorumPeer.quorumVerifier. QuorumVerifier was expanded and now has methods such as getAllMembers(), getVotingMembers(), getObservingMembers(). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira