You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2023/03/17 20:58:22 UTC
[GitHub] [hudi] jonvex opened a new pull request, #8225: fix to get rid of another issue
jonvex opened a new pull request, #8225:
URL: https://github.com/apache/hudi/pull/8225
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8225: [DO NOT REVIEW] [DO NOT MERGE] Bootstrap Performance
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8225:
URL: https://github.com/apache/hudi/pull/8225#issuecomment-1478144981
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773",
"triggerID" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"triggerType" : "PUSH"
}, {
"hash" : "0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15833",
"triggerID" : "0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90a62c81f6240ea04d772b14d2f2c16ae23ad9b9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773)
* 0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15833)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8225: fix to get rid of another issue
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8225:
URL: https://github.com/apache/hudi/pull/8225#issuecomment-1474428513
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90a62c81f6240ea04d772b14d2f2c16ae23ad9b9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jonvex commented on a diff in pull request #8225: [DO NOT REVIEW] [DO NOT MERGE] Bootstrap Performance
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on code in PR #8225:
URL: https://github.com/apache/hudi/pull/8225#discussion_r1143605051
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala:
##########
@@ -480,7 +481,9 @@ abstract class HoodieBaseRelation(val sqlContext: SQLContext,
try {
val tableConfig = metaClient.getTableConfig
if (extractPartitionValuesFromPartitionPath) {
- val relativePath = new URI(metaClient.getBasePath).relativize(new URI(file.getPath.getParent.toString)).toString
+ val tablePathWithoutScheme = CachingPath.getPathWithoutSchemeAndAuthority(metaClient.getBasePathV2)
+ val partitionPathWithoutScheme = CachingPath.getPathWithoutSchemeAndAuthority(file.getPath.getParent)
+ val relativePath = new URI(tablePathWithoutScheme.toString).relativize(new URI(partitionPathWithoutScheme.toString)).toString
val hiveStylePartitioningEnabled = tableConfig.getHiveStylePartitioningEnable.toBoolean
Review Comment:
clustering issue, ignore for perf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jonvex commented on a diff in pull request #8225: [DO NOT REVIEW] [DO NOT MERGE] Bootstrap Performance
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex commented on code in PR #8225:
URL: https://github.com/apache/hudi/pull/8225#discussion_r1143604434
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java:
##########
@@ -368,9 +368,6 @@ private Dataset<Row> readRecordsForGroupAsRow(JavaSparkContext jsc,
.stream()
.map(op -> {
ArrayList<String> readPaths = new ArrayList<>();
- if (op.getBootstrapFilePath() != null) {
- readPaths.add(op.getBootstrapFilePath());
- }
if (op.getDataFilePath() != null) {
Review Comment:
Clustering fix, ignore for perf
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -143,7 +143,7 @@ public List<HoodieFileGroup> addFilesToView(FileStatus[] statuses) {
// Group by partition for efficient updates for both InMemory and DiskBased structures.
fileGroups.stream().collect(Collectors.groupingBy(HoodieFileGroup::getPartitionPath)).forEach((partition, value) -> {
if (!isPartitionAvailableInStore(partition)) {
- if (bootstrapIndex.useIndex()) {
+ if (!partition.isEmpty() && bootstrapIndex.useIndex()) {
try (BootstrapIndex.IndexReader reader = bootstrapIndex.createReader()) {
Review Comment:
ignore for perf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jonvex closed pull request #8225: [DO NOT REVIEW] [DO NOT MERGE] Bootstrap Performance
Posted by "jonvex (via GitHub)" <gi...@apache.org>.
jonvex closed pull request #8225: [DO NOT REVIEW] [DO NOT MERGE] Bootstrap Performance
URL: https://github.com/apache/hudi/pull/8225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8225: [DO NOT REVIEW] [DO NOT MERGE] Bootstrap Performance
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8225:
URL: https://github.com/apache/hudi/pull/8225#issuecomment-1478117189
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773",
"triggerID" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"triggerType" : "PUSH"
}, {
"hash" : "0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90a62c81f6240ea04d772b14d2f2c16ae23ad9b9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773)
* 0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8225: [DO NOT REVIEW] [DO NOT MERGE] Bootstrap Performance
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8225:
URL: https://github.com/apache/hudi/pull/8225#issuecomment-1478345256
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773",
"triggerID" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"triggerType" : "PUSH"
}, {
"hash" : "0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15833",
"triggerID" : "0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0412d5eaa4deb05c7ff0569eea5fb4af2263fb9f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15833)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8225: fix to get rid of another issue
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8225:
URL: https://github.com/apache/hudi/pull/8225#issuecomment-1474525639
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773",
"triggerID" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90a62c81f6240ea04d772b14d2f2c16ae23ad9b9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8225: fix to get rid of another issue
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8225:
URL: https://github.com/apache/hudi/pull/8225#issuecomment-1474434417
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773",
"triggerID" : "90a62c81f6240ea04d772b14d2f2c16ae23ad9b9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 90a62c81f6240ea04d772b14d2f2c16ae23ad9b9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15773)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org