You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/13 19:29:44 UTC
[GitHub] [lucene-solr] arafalov opened a new pull request #1865: SOLR-14862: Update RefGuide page for support fied types
arafalov opened a new pull request #1865:
URL: https://github.com/apache/lucene-solr/pull/1865
# Description
The RefGuide page was missing some types and had too many Deprecated types in the same table as active types, which made it a bit hard to scan.
# Solution
- Went through the 8.6 javadoc and included missing field types in the Ref Guide page
- Added small placeholder description in other page where the types had no mention at all
- Moved Deprecated types into their own table
- Added some cross-references, for improved linking and understanding
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [X] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] epugh commented on pull request #1865: SOLR-14862: Update RefGuide page for support fied types
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #1865:
URL: https://github.com/apache/lucene-solr/pull/1865#issuecomment-692019738
I read through the text and it LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on pull request #1865: SOLR-14862: Update RefGuide page for support fied types
Posted by GitBox <gi...@apache.org>.
ctargett commented on pull request #1865:
URL: https://github.com/apache/lucene-solr/pull/1865#issuecomment-706294638
> This means the other change in this PR to document the Ranking Parser is not in branch_8x either and I don't intend to chase that down to backport it.
Scratch that. The field type changes have a link to the docs so I have to bring that back too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on pull request #1865: SOLR-14862: Update RefGuide page for support fied types
Posted by GitBox <gi...@apache.org>.
ctargett commented on pull request #1865:
URL: https://github.com/apache/lucene-solr/pull/1865#issuecomment-706288107
FYI, the field type doc improvements weren't backported to branch_8x which caused me merge conflicts with some other general cleanups I did on master and wanted to backport. I don't know of a reason not to backport them, so as part of fixing my merge conflicts I'm going to make branch_8x the same as master for that file. Please let me know if the information is not the same in 8.7 so we can fix that before release.
This means the other change in this PR to document the Ranking Parser is not in branch_8x either and I don't intend to chase that down to backport it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] arafalov merged pull request #1865: SOLR-14862: Update RefGuide page for support fied types
Posted by GitBox <gi...@apache.org>.
arafalov merged pull request #1865:
URL: https://github.com/apache/lucene-solr/pull/1865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org