You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/22 15:40:39 UTC

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2020: SOLR-14949: Ability to customize Solr Docker build

HoustonPutman opened a new pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020


   https://issues.apache.org/jira/browse/SOLR-14949
   
   Custom inputs:
   - Docker Image repo
   - Docker Image tag
   - Docker Image name
   - Base Docker Image
   
   Also added a gradlew helpDocker page.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] dsmiley commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-727655114


   FWIW I don't think /help/docker.txt is a good place for this because the Docker module has it's very own folder, and so shouldn't it go there?  I've been poking around the docker support today in the docker folder and had no clue this help file existed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510994999



##########
File path: solr/docker/tests/cases/version/test.sh
##########
@@ -1,45 +0,0 @@
-#!/bin/bash

Review comment:
       Yeah, this is something that might be useful when we start creating release artifacts, but the test we want will probably look quite different. This is pretty shallow and doesn't actually provide a whole lot.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] dweiss commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-724260281


   Hmm... sorry, missed your mention/ request somehow. Yeah - these functions are intended to read variables from multiple locations so it looks ok to me. I didn't test it (or use docker much for that matter).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-724264582


   Thanks for the sanity check!
   
   I've tested pretty thoroughly, and the PR test does some checks on its own too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510997092



##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin, https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all accepted via both Environment Variables and Gradle Properties.
+
+Docker Image Repository:
+   Default: "apache/solr"
+   EnvVar: DOCKER_SOLR_IMAGE_REPO
+   Gradle Property: -Pdocker.solr.imageRepo

Review comment:
       I could go either way. 
   
   Say we add a prometheus exporter. Which would we prefer?
   - `docker.solr.imageRepo` and `docker.prometheusExporter.imageRepo`
   - `solr.docker.imageRepo` and `prometheusExporter.docker.imageRepo`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-728176570


   That's fair, we can certainly move it. I included it there because that seemed like the place to put help files for gradle usage. All of the files used in the `help.gradle` are in that directory, but I guess there's no actual requirement for that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman commented on pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#issuecomment-717343306


   @dweiss Is the way I am declaring and obtaining variables the correct way of doing it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510995608



##########
File path: .github/workflows/docker-test.yml
##########
@@ -17,6 +17,10 @@ jobs:
 
     runs-on: ubuntu-latest
 
+    env:
+      DOCKER_SOLR_IMAGE_REPO: github-pr/solr

Review comment:
       nah this doesn't actually push. It's just testing that the custom repo/tag works.
   
   I'm pretty sure it would fail if it tried, because github-pr isn't a docker hub repo.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r512825250



##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin, https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all accepted via both Environment Variables and Gradle Properties.
+
+Docker Image Repository:
+   Default: "apache/solr"
+   EnvVar: DOCKER_SOLR_IMAGE_REPO
+   Gradle Property: -Pdocker.solr.imageRepo

Review comment:
       Nevermind, I agree with you. Made the changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] madrob commented on a change in pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020#discussion_r510986901



##########
File path: .github/workflows/docker-test.yml
##########
@@ -17,6 +17,10 @@ jobs:
 
     runs-on: ubuntu-latest
 
+    env:
+      DOCKER_SOLR_IMAGE_REPO: github-pr/solr

Review comment:
       Does this mean we will publish all of our PR docker images somewhere?

##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin, https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all accepted via both Environment Variables and Gradle Properties.
+
+Docker Image Repository:
+   Default: "apache/solr"
+   EnvVar: DOCKER_SOLR_IMAGE_REPO
+   Gradle Property: -Pdocker.solr.imageRepo

Review comment:
       Should this be solr.docker instead of docker.solr?

##########
File path: solr/docker/tests/cases/version/test.sh
##########
@@ -1,45 +0,0 @@
-#!/bin/bash

Review comment:
       Deleted because we can set the tag and version to be anything now?

##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin, https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all accepted via both Environment Variables and Gradle Properties.

Review comment:
       s/it's/its

##########
File path: help/docker.txt
##########
@@ -0,0 +1,53 @@
+Docker Images for Solr
+======================
+
+Solr docker images are built using Palantir's Docker Gradle plugin, https://github.com/palantir/gradle-docker.
+
+Common Inputs
+-------------
+
+The docker image and it's tag can be customized via the following options, all accepted via both Environment Variables and Gradle Properties.
+
+Docker Image Repository:
+   Default: "apache/solr"
+   EnvVar: DOCKER_SOLR_IMAGE_REPO
+   Gradle Property: -Pdocker.solr.imageRepo
+
+Docker Image Tag:
+   Default: the Solr version, e.g. "9.0.0-SNAPSHOT"
+   EnvVar: DOCKER_SOLR_IMAGE_TAG
+   Gradle Property: -Pdocker.solr.imageTag
+
+Docker Image Name: (Use this to explicitly set a whole image name. If given, the image repo and image version options above are ignored.)
+   Default: {image_repo}/{image_tag} (both options provided above, with defaults)
+   EnvVar: DOCKER_SOLR_IMAGE_NAME
+   Gradle Property: -Pdocker.solr.imageName
+
+Building
+--------
+
+In order to build the Solr Docker image, run:
+
+gradlew docker
+
+The docker build task (`gradlew docker`) accepts the following inputs, in addition to the common inputs listed above:

Review comment:
       This is displayed as plain text, not markdown.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] HoustonPutman merged pull request #2020: SOLR-14949: Ability to customize Solr Docker build

Posted by GitBox <gi...@apache.org>.
HoustonPutman merged pull request #2020:
URL: https://github.com/apache/lucene-solr/pull/2020


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org