You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2021/07/08 07:56:53 UTC
[ofbiz-framework] branch trunk updated: Improved: Clean commented
code from ofbiz services (#310)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new cd40cc2 Improved: Clean commented code from ofbiz services (#310)
cd40cc2 is described below
commit cd40cc28a708880f646c442ffd2ae6b74248de66
Author: Eugen Stan <ie...@apache.org>
AuthorDate: Thu Jul 8 10:56:44 2021 +0300
Improved: Clean commented code from ofbiz services (#310)
(OFBIZ-8040)
---
.../src/main/java/org/apache/ofbiz/service/ModelService.java | 12 ------------
.../apache/ofbiz/service/test/ServiceEntityAutoTests.java | 1 -
2 files changed, 13 deletions(-)
diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/ModelService.java b/framework/service/src/main/java/org/apache/ofbiz/service/ModelService.java
index 2df5f72..3f81a6d 100644
--- a/framework/service/src/main/java/org/apache/ofbiz/service/ModelService.java
+++ b/framework/service/src/main/java/org/apache/ofbiz/service/ModelService.java
@@ -986,18 +986,6 @@ public class ModelService extends AbstractMap<String, Object> implements Seriali
}
}
- /* DEJ20060125 This is private but not used locally, so just commenting it out for now... may remove later
- private void copyParams(Collection params) {
- if (params != null) {
- Iterator i = params.iterator();
- while (i.hasNext()) {
- ModelParam param = (ModelParam) i.next();
- addParam(param);
- }
- }
- }
- */
-
/**
* Adds a clone of a parameter definition to this service
*/
diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/test/ServiceEntityAutoTests.java b/framework/service/src/main/java/org/apache/ofbiz/service/test/ServiceEntityAutoTests.java
index 0bae5f6..365ce06 100644
--- a/framework/service/src/main/java/org/apache/ofbiz/service/test/ServiceEntityAutoTests.java
+++ b/framework/service/src/main/java/org/apache/ofbiz/service/test/ServiceEntityAutoTests.java
@@ -107,7 +107,6 @@ public class ServiceEntityAutoTests extends OFBizTestCase {
//test collision
results = getDispatcher().runSync("testEntityAutoCreateTestingItemPkPresent", testingItemPkPresentMap, 10, true);
assertTrue(ServiceUtil.isError(results));
- //assertEquals("", ServiceUtil.getErrorMessage(results));
}
/**