You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jianxia Chen <jc...@pivotal.io> on 2016/06/03 23:42:11 UTC
Review Request 48239: GEODE-1498 CI Failure:
DurableClientCommandsDUnitTest.testCloseDurableClients
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48239/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
Repository: geode
Description
-------
Use port 0 for cache server and return a random available for durable client.
Diffs
-----
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java c51f875
Diff: https://reviews.apache.org/r/48239/diff/
Testing
-------
Thanks,
Jianxia Chen
Re: Review Request 48239: GEODE-1498 CI Failure:
DurableClientCommandsDUnitTest.testCloseDurableClients
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48239/#review136142
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On June 3, 2016, 11:42 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48239/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 11:42 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Use port 0 for cache server and return a random available for durable client.
>
>
> Diffs
> -----
>
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java c51f875
>
> Diff: https://reviews.apache.org/r/48239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 48239: GEODE-1498 CI Failure:
DurableClientCommandsDUnitTest.testCloseDurableClients
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48239/#review136217
-----------------------------------------------------------
Ship it!
geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java (line 248)
<https://reviews.apache.org/r/48239/#comment201231>
this could have been replaced with the lambda equivalent of ```java int listeningPort = server1.invoke("...", () -> startCacheServer(0,false,regionName))```
- Udo Kohlmeyer
On June 3, 2016, 11:42 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48239/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 11:42 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Use port 0 for cache server and return a random available for durable client.
>
>
> Diffs
> -----
>
> geode-cq/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/DurableClientCommandsDUnitTest.java c51f875
>
> Diff: https://reviews.apache.org/r/48239/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>