You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2018/01/11 12:18:33 UTC
[GitHub] brooklyn-server pull request #929: Fix icons in catalog, and a few misc
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/929
Fix icons in catalog, and a few misc
icons set on catalog items previously could only come in metadata, unlike name and description which could be in metadata _or_ in the `item` yaml. as setting an `iconUrl` in the item yaml is valid (like `description` and display `name`), we should also special case check this when preparing catalog item metadata, treating all three the same. see the most recent commit.
this fixes a bug where the icons in `policy/src/main/resource/catalog.bom` weren't getting picked up in the catalog (but they were being seen when instances were deployed).
two tiny other commits which i've noticed in the course of debugging also
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server fix-policy-icons-and-misc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/929.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #929
----
commit c8452e38208a48b2ff21a616ac11e08b75248303
Author: Alex Heneveld <al...@...>
Date: 2018-01-11T11:12:16Z
fix config key name spelling in dynamic fabric java
commit 1b1e7853832a5e06e017e412954bc99c3c2afa90
Author: Alex Heneveld <al...@...>
Date: 2018-01-11T11:13:40Z
only declare version once
commit 26b8f4f95bdaf279d5ac387a22cc5030f4362229
Author: Alex Heneveld <al...@...>
Date: 2018-01-11T11:45:36Z
allow iconUrl to come from item, match behaviour for name and description
----
---
[GitHub] brooklyn-server pull request #929: Fix icons in catalog, and a few misc
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/929#discussion_r160979484
--- Diff: core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabric.java ---
@@ -55,14 +55,14 @@
@SetFromFlag("memberSpec")
ConfigKey<EntitySpec<?>> MEMBER_SPEC = ConfigKeys.newConfigKey(
new TypeToken<EntitySpec<?>>() {},
- "dynamiccfabric.memberspec",
+ "dynamicfabric.memberspec",
--- End diff --
Strictly speaking, we should use the `deprecatedNames` to leave support for the old badly spelt name. However, it's unlikely that anyone is using the misspelt name so no strong feelings.
As an example of the deprecation usage:
```
public static final ConfigKey<Boolean> START_LATCH = ConfigKeys.builder(Boolean.class)
.name("latch.start")
.deprecatedNames("start.latch")
.description("Latch for blocking start (done post-provisioning for software processes); if non-null will wait for this to resolve (normal use is with '$brooklyn:attributeWhenReady')")
.build();
```
---
[GitHub] brooklyn-server issue #929: Fix icons in catalog, and a few misc
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/929
LGTM; merging.
---
[GitHub] brooklyn-server pull request #929: Fix icons in catalog, and a few misc
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/929
---