You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/01/31 11:20:51 UTC
[GitHub] [hadoop] 9uapaw opened a new pull request #3946: YARN-11070. Minimum resource ratio is overridden by subsequent labels
9uapaw opened a new pull request #3946:
URL: https://github.com/apache/hadoop/pull/3946
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
### How was this patch tested?
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] brumi1024 commented on a change in pull request #3946: YARN-11070. Minimum resource ratio is overridden by subsequent labels
Posted by GitBox <gi...@apache.org>.
brumi1024 commented on a change in pull request #3946:
URL: https://github.com/apache/hadoop/pull/3946#discussion_r795761880
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java
##########
@@ -105,7 +106,7 @@
// leaf queue can use this to calculate effective resources.
// This field will not be edited, reference will point to a new immutable map
Review comment:
AFAIK this isn't true anymore.
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/ParentQueue.java
##########
@@ -1328,8 +1329,8 @@ private void calculateEffectiveResourcesAndCapacity(String label,
}
}
- effectiveMinRatioPerResource = getEffectiveMinRatioPerResource(
- configuredMinResources, numeratorForMinRatio);
+ effectiveMinRatioPerResource.put(label, getEffectiveMinRatioPerResource(
Review comment:
Nit/idea: I think a name like effectiveMinResourceRatio is a bit more descriptive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] szilard-nemeth closed pull request #3946: YARN-11070. Minimum resource ratio is overridden by subsequent labels
Posted by GitBox <gi...@apache.org>.
szilard-nemeth closed pull request #3946:
URL: https://github.com/apache/hadoop/pull/3946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] szilard-nemeth commented on pull request #3946: YARN-11070. Minimum resource ratio is overridden by subsequent labels
Posted by GitBox <gi...@apache.org>.
szilard-nemeth commented on pull request #3946:
URL: https://github.com/apache/hadoop/pull/3946#issuecomment-1043306198
Hi @9uapaw ,
Thanks for working on this.
Patch LGTM, committed to trunk.
Thanks @brumi1024for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org