You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/08/01 19:49:54 UTC

Re: Review Request 24113: Patch for KAFKA-1562

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24113/#review49359
-----------------------------------------------------------


Thanks for the patch. A couple of comments below.


core/src/main/scala/kafka/admin/TopicCommand.scala
<https://reviews.apache.org/r/24113/#comment86356>

    Would it be better to just fetch the topic config once before line 98?



core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala
<https://reviews.apache.org/r/24113/#comment86357>

    For this particular test, not sure we need to create the brokers since we are just testing if the values in ZK are correct.


- Jun Rao


On July 30, 2014, 8:51 p.m., Jonathan Natkins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24113/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 8:51 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1562
>     https://issues.apache.org/jira/browse/KAFKA-1562
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1562 kafka-topics.sh alter add partitions resets cleanup.policy
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/admin/AdminUtils.scala b5d8714e964fee8b29b05db04d79fd6ac84f3e48 
>   core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf 
>   core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24113/diff/
> 
> 
> Testing
> -------
> 
> Automated
> 
> 
> Thanks,
> 
> Jonathan Natkins
> 
>