You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/02/14 23:59:55 UTC
[kudu-CR] KUDU-1877. Properly link to https:// URLs when SSL is enabled
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6007
to review the following change.
Change subject: KUDU-1877. Properly link to https:// URLs when SSL is enabled
......................................................................
KUDU-1877. Properly link to https:// URLs when SSL is enabled
This adds an https_enabled field to the registration protobuf, and makes
the web pages that generate links use https:// URLs when it is set.
Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
---
M src/kudu/common/wire_protocol.proto
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master.cc
M src/kudu/tserver/heartbeater.cc
5 files changed, 54 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/6007/1
--
To view, visit http://gerrit.cloudera.org:8080/6007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] KUDU-1877. Properly link to https:// URLs when SSL is enabled
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6007
to look at the new patch set (#2).
Change subject: KUDU-1877. Properly link to https:// URLs when SSL is enabled
......................................................................
KUDU-1877. Properly link to https:// URLs when SSL is enabled
This adds an https_enabled field to the registration protobuf, and makes
the web pages that generate links use https:// URLs when it is set.
Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
---
M src/kudu/common/wire_protocol.proto
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master.cc
M src/kudu/tserver/heartbeater.cc
5 files changed, 54 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/6007/2
--
To view, visit http://gerrit.cloudera.org:8080/6007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1877. Properly link to https:// URLs when SSL is enabled
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1877. Properly link to https:// URLs when SSL is enabled
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6007/1/src/kudu/integration-tests/registration-test.cc
File src/kudu/integration-tests/registration-test.cc:
Line 220: TEST_F(RegistrationTest, TestExposeHttpsURLs) {
> I thought about testing /masters but it was a pain because MiniMaster doesn
Nah, I didn't think it was necessarily worth it either.
--
To view, visit http://gerrit.cloudera.org:8080/6007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1877. Properly link to https:// URLs when SSL is enabled
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1877. Properly link to https:// URLs when SSL is enabled
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6007/1/src/kudu/integration-tests/registration-test.cc
File src/kudu/integration-tests/registration-test.cc:
Line 220: TEST_F(RegistrationTest, TestExposeHttpsURLs) {
Worth also testing the other pages that expose links, like /masters or /table?
Line 244: }, MonoDelta::FromSeconds(10));
Could we do without the customization of the timeout?
--
To view, visit http://gerrit.cloudera.org:8080/6007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1877. Properly link to https:// URLs when SSL is enabled
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1877. Properly link to https:// URLs when SSL is enabled
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6007/1/src/kudu/integration-tests/registration-test.cc
File src/kudu/integration-tests/registration-test.cc:
Line 220: TEST_F(RegistrationTest, TestExposeHttpsURLs) {
> Worth also testing the other pages that expose links, like /masters or /tab
I thought about testing /masters but it was a pain because MiniMaster doesn't expose MasterOptions and I didn't want to do the plumbing. Mind if I am lazy about this one?
Line 244: }, MonoDelta::FromSeconds(10));
> Could we do without the customization of the timeout?
oh, I forgot there was a default. will do.
--
To view, visit http://gerrit.cloudera.org:8080/6007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1877. Properly link to https:// URLs when SSL is enabled
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1877. Properly link to https:// URLs when SSL is enabled
......................................................................
KUDU-1877. Properly link to https:// URLs when SSL is enabled
This adds an https_enabled field to the registration protobuf, and makes
the web pages that generate links use https:// URLs when it is set.
Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
Reviewed-on: http://gerrit.cloudera.org:8080/6007
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/common/wire_protocol.proto
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master.cc
M src/kudu/tserver/heartbeater.cc
5 files changed, 54 insertions(+), 6 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ee1ac2c577c0a1a9a6b67f26c4515c3d1ce6dad
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>