You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by agoodm <gi...@git.apache.org> on 2016/10/22 00:37:08 UTC
[GitHub] climate pull request #416: CLIMATE-883 - Ensure python 3 builds pass unit te...
GitHub user agoodm opened a pull request:
https://github.com/apache/climate/pull/416
CLIMATE-883 - Ensure python 3 builds pass unit tests
This PR should solve most of the Python 3 compatibility issues we have been having. The biggest ones remaining are some of our examples as well as `run_RCMES.py`. I included a minor hotfix to an issue with that file as well for the sake of ensuring these changes don't break our workflow in Python 2.7.
In addition to unit tests, I also ran the podaac example and other than some deprecation warnings, everything seems good.
@lewismc @huikyole please review / comment. I have tested one config file for CORDEX Africa and it worked, but feel free to perform any other tests as you see fit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agoodm/climate CLIMATE-883
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit 528fe168c007ca3509f23f0bec9157fc0b2801be
Author: Alex Goodman <ag...@users.noreply.github.com>
Date: 2016-10-21T23:47:49Z
CLIMATE-883 - Ensure python 3 builds pass unit tests
commit 4331ed08874b5a64cb1d82276db1e707619e600f
Author: Alex Goodman <ag...@users.noreply.github.com>
Date: 2016-10-22T00:30:08Z
Fix minor error in run_RCMES.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #416: CLIMATE-883 - Ensure python 3 builds pass unit te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/climate/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #416: CLIMATE-883 - Ensure python 3 builds pass unit te...
Posted by agoodm <gi...@git.apache.org>.
GitHub user agoodm reopened a pull request:
https://github.com/apache/climate/pull/416
CLIMATE-883 - Ensure python 3 builds pass unit tests
This PR should solve most of the Python 3 compatibility issues we have been having. The biggest ones remaining are some of our examples as well as `run_RCMES.py`. I included a minor hotfix to an issue with that file as well for the sake of ensuring these changes don't break our workflow in Python 2.7.
In addition to unit tests, I also ran the podaac example and other than some deprecation warnings, everything seems good.
@lewismc @huikyole please review / comment. I have tested one config file for CORDEX Africa and it worked, but feel free to perform any other tests as you see fit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agoodm/climate CLIMATE-883
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit 528fe168c007ca3509f23f0bec9157fc0b2801be
Author: Alex Goodman <ag...@users.noreply.github.com>
Date: 2016-10-21T23:47:49Z
CLIMATE-883 - Ensure python 3 builds pass unit tests
commit 4331ed08874b5a64cb1d82276db1e707619e600f
Author: Alex Goodman <ag...@users.noreply.github.com>
Date: 2016-10-22T00:30:08Z
Fix minor error in run_RCMES.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #416: CLIMATE-883 - Ensure python 3 builds pass unit tests
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/416
+1 from me
On Monday, October 24, 2016, Alex Goodman <no...@github.com> wrote:
> Fixed. Once again CI build failure seems to be due to connectivity issues,
> so I will merge later today if no further discussion.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/climate/pull/416#issuecomment-255831609>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABHJlyWYQjNexzz1Y68qFZIPlNXC_ZWBks5q3P7AgaJpZM4KdtJr>
> .
>
--
*Lewis*
Dr. Lewis J. McGibbney Ph.D, B.Sc
Director, MCMA Associates
Phone: +1(626)498-3090
Skype: lewis.john.mcgibbney
Email: lewis.mcgibbney@gmail.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #416: CLIMATE-883 - Ensure python 3 builds pass unit tests
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the issue:
https://github.com/apache/climate/pull/416
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #416: CLIMATE-883 - Ensure python 3 builds pass unit te...
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/climate/pull/416#discussion_r84599868
--- Diff: ocw/data_source/rcmed.py ---
@@ -74,7 +79,8 @@ def _make_mask_array(values, parameter_id, parameters_metadata):
'''
for each in parameters_metadata:
- if each['parameter_id'].encode() == str(parameter_id):
+ if str(each['parameter_id']) == str(parameter_id):
+ print('ok')
--- End diff --
Can remove this logging @agoodm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #416: CLIMATE-883 - Ensure python 3 builds pass unit tests
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/climate/pull/416
Fixed. Once again CI build failure seems to be due to connectivity issues, so I will merge later today if no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #416: CLIMATE-883 - Ensure python 3 builds pass unit tests
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/climate/pull/416
Restarting because one of the builds failed due to connection issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #416: CLIMATE-883 - Ensure python 3 builds pass unit te...
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm closed the pull request at:
https://github.com/apache/climate/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---