You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/20 09:11:30 UTC

[GitHub] [beam] kamilwu commented on a change in pull request #11738: [BEAM-9936] Create SDK harness containers with Python 3.8

kamilwu commented on a change in pull request #11738:
URL: https://github.com/apache/beam/pull/11738#discussion_r427859015



##########
File path: sdks/python/container/run_validatescontainer.sh
##########
@@ -69,8 +71,13 @@ elif [[ $1 == "python37" ]]; then
   CONTAINER_PROJECT="sdks:python:container:py37"  # Use this to build container by Gradle.
   GRADLE_PY3_FLAG="-Ppython3"   # Use this in Gradle command.
   PY_INTERPRETER="python3.7"    # Use this in virtualenv command.
+elif [[ $1 == "python38" ]]; then
+  IMAGE_NAME="${IMAGE_PREFIX}python3.8_sdk"    # Use this to create CONTAINER_IMAGE variable.
+  CONTAINER_PROJECT="sdks:python:container:py38"  # Use this to build container by Gradle.
+  GRADLE_PY3_FLAG="-Ppython3"   # Use this in Gradle command.

Review comment:
       Indeed there's no difference after removal. Looks like it was a leftover junk.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org