[GitHub] [openwhisk] bdoyle0182 commented on pull request #5024: Reset / Overwrite invokerId for unique name in zookeeper manually

[GitBox <gi...@apache.org>]

bdoyle0182 commented on pull request #5024:
URL: https://github.com/apache/openwhisk/pull/5024#issuecomment-726353524


   I made a couple changes to make this better and assigning ids more infallible:
   
   1. As noted in the discussion above, if the invoker id existing for another name; it will delete that mapping before reassigning to the new name.
   2. You can't overwrite with an invoker id that doesn't fit into the size of the invoker pool. i.e. if the invoker pool is size 2, I can't overwrite with id 2. only 0 or 1.
   3. When dynamically assigning a new id, it now does so based on the number of invoker nodes in the zookeeper list rather than the atomic count. That way when reassigning things, it will always stay in sync with the true size of invokers if assigning a new id dynamically. This should maintain atomicity because it still uses the atomic counter as a lock and will re get the invokers size if it doesn't acquire the lock and would then include the new invoker that had the lock at the time. This is important to do because obviously it better tracks the true size of your invoker fleet and is important for allowing overwriting. For example, we want to move invokers 25-30 to invokers 0-5. When we do that, 25-30 would no longer exist; but our counter is still at 31 so if we add a new node it will be 31 leaving 25-30 forever empty. With this change, after moving 25-30 to 0-5 it will recognize there's actually only 25 invokers so when we add a new node it will correctly use 25 for the new node
 .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org