You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/03/22 22:12:45 UTC

[GitHub] [hadoop] steveloughran commented on pull request #2731: HADOOP-17471. ABFS to collect IOStatistics

steveloughran commented on pull request #2731:
URL: https://github.com/apache/hadoop/pull/2731#issuecomment-804430014


   Looks great!
   My main production suggestion is to make the counters a DurationTrackerFactory, giving us the option of feeding it in to anything we add in Hadoop common &c to take one. 
   test code: can you use assertThatStatisticMean() for your stats asserts -and if not, are changes needed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org