You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "Mmuzaf (via GitHub)" <gi...@apache.org> on 2023/02/27 16:41:16 UTC
[GitHub] [cassandra] Mmuzaf opened a new pull request, #2178: CASSANDRA-18131 Fix LongBTreeTest test timeout
Mmuzaf opened a new pull request, #2178:
URL: https://github.com/apache/cassandra/pull/2178
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2178: CASSANDRA-18131 Fix LongBTreeTest test timeout
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2178:
URL: https://github.com/apache/cassandra/pull/2178#discussion_r1155339422
##########
test/burn/org/apache/cassandra/utils/LongBTreeTest.java:
##########
@@ -785,7 +784,7 @@ public void testBatchesSmallOverlappingRange() throws ExecutionException, Interr
@Test
public void testIndividualInsertsMediumSparseRange() throws ExecutionException, InterruptedException
{
- testInsertions(randomSeed(), perThreadTrees / 10, 500, 10, 1, true);
+ testInsertions(randomSeed(), 500, 10, 1, true);
Review Comment:
the default value of this `tests` parameter is `perThreadTrees * threads`, so we could be replacing values of `1000` with `25600` (where there are 32 availableProcessors). Note in ant we limit this to `2 processors` [here|https://github.com/apache/cassandra/blob/trunk/build.xml#L127] so a value of `1600` (which is still an increase).
is this what you intended @Mmuzaf ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] Mmuzaf commented on a diff in pull request #2178: CASSANDRA-18131 Fix LongBTreeTest test timeout
Posted by "Mmuzaf (via GitHub)" <gi...@apache.org>.
Mmuzaf commented on code in PR #2178:
URL: https://github.com/apache/cassandra/pull/2178#discussion_r1155358445
##########
test/burn/org/apache/cassandra/utils/LongBTreeTest.java:
##########
@@ -785,7 +784,7 @@ public void testBatchesSmallOverlappingRange() throws ExecutionException, Interr
@Test
public void testIndividualInsertsMediumSparseRange() throws ExecutionException, InterruptedException
{
- testInsertions(randomSeed(), perThreadTrees / 10, 500, 10, 1, true);
+ testInsertions(randomSeed(), 500, 10, 1, true);
Review Comment:
It is also possible to just set the `perThreadTrees` for 10000 back to 100 as an _easy fix_, I guess. I just wanted to fix the problem wider and maybe I overdid it :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-18131 Fix LongBTreeTest test timeout [cassandra]
Posted by "pmcfadin (via GitHub)" <gi...@apache.org>.
pmcfadin closed pull request #2178: CASSANDRA-18131 Fix LongBTreeTest test timeout
URL: https://github.com/apache/cassandra/pull/2178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] Mmuzaf commented on a diff in pull request #2178: CASSANDRA-18131 Fix LongBTreeTest test timeout
Posted by "Mmuzaf (via GitHub)" <gi...@apache.org>.
Mmuzaf commented on code in PR #2178:
URL: https://github.com/apache/cassandra/pull/2178#discussion_r1155357680
##########
test/burn/org/apache/cassandra/utils/LongBTreeTest.java:
##########
@@ -785,7 +784,7 @@ public void testBatchesSmallOverlappingRange() throws ExecutionException, Interr
@Test
public void testIndividualInsertsMediumSparseRange() throws ExecutionException, InterruptedException
{
- testInsertions(randomSeed(), perThreadTrees / 10, 500, 10, 1, true);
+ testInsertions(randomSeed(), 500, 10, 1, true);
Review Comment:
Correct, I think we can safely increase the number of local runs for `testLargeBatchesLargeRange`, and `testIndividualInsertsMediumSparseRange` while still maintaining a reasonable execution time for the LongBTreeTest as a whole.
For the tests that fire `testInsertions` with parameters the main concern we have is - we perform different numbers of test attempts to check tree insertions for variations of ranges and batches, but the same equal number of `tests` should be used for all of them. I think `perThreadTrees * threads` is the better choice for us since increasing the `perThreadTrees` (for `testInsertions` it's not exactly trees per thread as it says, it's just a multiplier) will give us the ability to find patterns e.g. for a heap consumption during a particular run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2178: CASSANDRA-18131 Fix LongBTreeTest test timeout
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2178:
URL: https://github.com/apache/cassandra/pull/2178#discussion_r1155339422
##########
test/burn/org/apache/cassandra/utils/LongBTreeTest.java:
##########
@@ -785,7 +784,7 @@ public void testBatchesSmallOverlappingRange() throws ExecutionException, Interr
@Test
public void testIndividualInsertsMediumSparseRange() throws ExecutionException, InterruptedException
{
- testInsertions(randomSeed(), perThreadTrees / 10, 500, 10, 1, true);
+ testInsertions(randomSeed(), 500, 10, 1, true);
Review Comment:
the default value of this `tests` parameter is `perThreadTrees * threads`, so we could be replacing values of `1000` with `25600` (where there are 32 availableProcessors). Note in ant we limit this to `2 processors` [here](https://github.com/apache/cassandra/blob/trunk/build.xml#L127) so a value of `1600` (which is still an increase).
is this what you intended @Mmuzaf ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-18131 Fix LongBTreeTest test timeout [cassandra]
Posted by "pmcfadin (via GitHub)" <gi...@apache.org>.
pmcfadin commented on PR #2178:
URL: https://github.com/apache/cassandra/pull/2178#issuecomment-4227142449
Closing as [CASSANDRA-18131](https://issues.apache.org/jira/browse/CASSANDRA-18131) has been resolved as Fixed — if this PR contains changes not captured in the merged fix, please reopen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org