You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2023/08/16 10:59:00 UTC

[GitHub] [airflow] Lee-W opened a new pull request, #33436: feat(providers/microsoft): add DefaultAzureCredential support to cosmos

Lee-W opened a new pull request, #33436:
URL: https://github.com/apache/airflow/pull/33436

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33436: feat(providers/microsoft): add DefaultAzureCredential support to cosmos

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33436:
URL: https://github.com/apache/airflow/pull/33436#issuecomment-1694203434

   > I notice the constrains keep failing. Is there anything I need to change for it?
   
   Fix for it in https://github.com/apache/airflow/pull/33774 -> they also fail in main and the reason is that we already relaxed the limit for hive provider for 3.11 but we have not released the matching version of hive provider yet in PyPI (we just made it possible back for the hive provider to work on 3.11 but it needs releasing a new provider version due to dependency changes required for 3.11). 
   
   The #33774 will skip over hive provider for 3.11 temporarily and we will remove it when we have the new hive provider


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Lee-W commented on pull request #33436: feat(providers/microsoft): add DefaultAzureCredential support to cosmos

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #33436:
URL: https://github.com/apache/airflow/pull/33436#issuecomment-1694143950

   I notice the constrains keep failing. Is there anything I need to change for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #33436: feat(providers/microsoft): add DefaultAzureCredential support to cosmos

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33436:
URL: https://github.com/apache/airflow/pull/33436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Lee-W commented on pull request #33436: feat(providers/microsoft): add DefaultAzureCredential support to cosmos

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #33436:
URL: https://github.com/apache/airflow/pull/33436#issuecomment-1694209435

   > > I notice the constrains keep failing. Is there anything I need to change for it?
   > 
   > Fix for it in #33774 -> they also fail in main and the reason is that we already relaxed the limit for hive provider for 3.11 but we have not released the matching version of hive provider yet in PyPI (we just made it possible back for the hive provider to work on 3.11 but it needs releasing a new provider version due to dependency changes required for 3.11).
   > 
   > The #33774 will skip over hive provider for 3.11 temporarily and we will remove it when we have the new hive provider
   
   Thanks for the detail explaining 🙂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #33436: feat(providers/microsoft): add DefaultAzureCredential support to cosmos

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33436:
URL: https://github.com/apache/airflow/pull/33436#issuecomment-1694203782

   We can merge it now even with failing constrainst (they also fail in main).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org