You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/01/31 13:08:08 UTC
[GitHub] [wicket] reiern70 commented on a change in pull request #496: [WICKET-6950] allow configuring web-sockets sessions when connection …
reiern70 commented on a change in pull request #496:
URL: https://github.com/apache/wicket/pull/496#discussion_r795652283
##########
File path: wicket-native-websocket/wicket-native-websocket-core/src/main/java/org/apache/wicket/protocol/ws/WebSocketSettings.java
##########
@@ -245,6 +246,16 @@ public Executor getSendPayloadExecutor()
return sendPayloadExecutor;
}
+ /**
+ * Allows to configure {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ *
+ * @param webSocketSession The {@link org.apache.wicket.protocol.ws.api.IWebSocketSession}
+ */
+ public void configureSession(IWebSocketSession webSocketSession)
Review comment:
Yes...you are right. We are somehow "forcing" the settings class to acta as a listener. Thus we might need to introduce a Listener/Configurer that is set in Setting and laster on called. This might be more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org