You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/04/25 09:59:06 UTC
[jira] Created: (HARMONY-405) Enable a few more test cases for JNDI
Enable a few more test cases for JNDI
-------------------------------------
Key: HARMONY-405
URL: http://issues.apache.org/jira/browse/HARMONY-405
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Richard Liang
Priority: Minor
I will analyze the excluded test cases and try to make them pass.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-405) Enable a few more test cases for JNDI
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-405?page=all ]
Richard Liang updated HARMONY-405:
----------------------------------
Attachment: jndi.diff
Hello,
Please try my patch :-)
1. Copy resources for serialization test cases
2. Comment out some 3 test cases which need complex configuration related to jndi properties
> Enable a few more test cases for JNDI
> -------------------------------------
>
> Key: HARMONY-405
> URL: http://issues.apache.org/jira/browse/HARMONY-405
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Priority: Minor
> Attachments: jndi.diff
>
> I will analyze the excluded test cases and try to make them pass.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-405) Enable a few more test cases for
JNDI
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-405?page=all ]
George Harley reassigned HARMONY-405:
-------------------------------------
Assign To: George Harley
> Enable a few more test cases for JNDI
> -------------------------------------
>
> Key: HARMONY-405
> URL: http://issues.apache.org/jira/browse/HARMONY-405
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assignee: George Harley
> Priority: Minor
> Attachments: jndi.diff
>
> I will analyze the excluded test cases and try to make them pass.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-405) Enable a few more test cases for
JNDI
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-405?page=all ]
George Harley resolved HARMONY-405:
-----------------------------------
Resolution: Fixed
Hi Richard,
Modified version of your changes committed in revision 396883. As the .ser files are test artifacts I renamed your new target "copy.test.resources" and also wired it up to "compile.tests" by making it a dependency of that target. The location of the .ser files was also changed to fit into previously agreed guidelines (i.e. under src/test/serialization/<package under test> ).
Please let me know if you are happy with these modifications and I will move to close out the issue.
Thanks for this patch.
Best regards,
George
> Enable a few more test cases for JNDI
> -------------------------------------
>
> Key: HARMONY-405
> URL: http://issues.apache.org/jira/browse/HARMONY-405
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assignee: George Harley
> Priority: Minor
> Attachments: jndi.diff
>
> I will analyze the excluded test cases and try to make them pass.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-405) Enable a few more test cases for JNDI
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-405?page=all ]
George Harley closed HARMONY-405:
---------------------------------
Verified by Richard.
Richard, to address your other points :-
> 1. Names of the test cases: All jnid tests named with TestXXXX.java, shall we rename them to XXXXTest.java?
Yes, that sounds like it will make the JNDI tests more consistent with the other modules. I will put this on my TODO list.
> 2. It seems that "jndi/src/test/resources/libs/jnditesthelper.zip" is not used, shall we remove this file?
A tentative yes to this one.
> Also I have created a page in Harmony wiki about our testing conventions
> (http://wiki.apache.org/harmony/Testing_Convention), would you please document our agreed guidelines
> about .ser files in this page? Thanks a lot.
OK. I have been meaning to do this for a while now.
Best regards,
George
> Enable a few more test cases for JNDI
> -------------------------------------
>
> Key: HARMONY-405
> URL: http://issues.apache.org/jira/browse/HARMONY-405
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assignee: George Harley
> Priority: Minor
> Attachments: jndi.diff
>
> I will analyze the excluded test cases and try to make them pass.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-405) Enable a few more test cases for
JNDI
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-405?page=comments#action_12376379 ]
Richard Liang commented on HARMONY-405:
---------------------------------------
Thanks a lot, George.
The fix works fine for me. However, there are still a few issues in jndi tests.
1. Names of the test cases: All jnid tests named with TestXXXX.java, shall we rename them to XXXXTest.java?
2. It seems that "jndi/src/test/resources/libs/jnditesthelper.zip" is not used, shall we remove this file?
Also I have created a page in Harmony wiki about our testing conventions (http://wiki.apache.org/harmony/Testing_Convention), would you please document our agreed guidelines about .ser files in this page? Thanks a lot.
> Enable a few more test cases for JNDI
> -------------------------------------
>
> Key: HARMONY-405
> URL: http://issues.apache.org/jira/browse/HARMONY-405
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Richard Liang
> Assignee: George Harley
> Priority: Minor
> Attachments: jndi.diff
>
> I will analyze the excluded test cases and try to make them pass.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira