You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by es...@apache.org on 2018/03/01 20:54:50 UTC
[geode] branch feature/GEODE-4721 updated: Fix a review comments.
This is an automated email from the ASF dual-hosted git repository.
eshu11 pushed a commit to branch feature/GEODE-4721
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/feature/GEODE-4721 by this push:
new 8174599 Fix a review comments.
8174599 is described below
commit 8174599c6cd44701e7d0df713f89f782b5c6b35b
Author: eshu <es...@pivotal.io>
AuthorDate: Thu Mar 1 12:54:12 2018 -0800
Fix a review comments.
---
.../geode/internal/cache/execute/PRSetOperationJTADUnitTest.java | 6 +++---
.../org/apache/geode/internal/jta/SetOperationJTAJUnitTest.java | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRSetOperationJTADUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRSetOperationJTADUnitTest.java
index 922287e..6abbff2 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRSetOperationJTADUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRSetOperationJTADUnitTest.java
@@ -179,7 +179,7 @@ public class PRSetOperationJTADUnitTest extends JUnit4CacheTestCase {
userTX.begin();
Collection<Long> set = region.keySet();
set.forEach((key) -> assertTrue(testData.keySet().contains(key)));
- testData.keySet().forEach((key) -> set.contains(key));
+ testData.keySet().forEach((key) -> assertTrue(set.contains(key)));
} finally {
validateTXManager(disableSetOpToStartJTA, isAccessor);
if (!disableSetOpToStartJTA && !isAccessor) {
@@ -197,7 +197,7 @@ public class PRSetOperationJTADUnitTest extends JUnit4CacheTestCase {
userTX.begin();
Collection<String> set = region.values();
set.forEach((value) -> assertTrue(testData.values().contains(value)));
- testData.values().forEach((value) -> set.contains(value));
+ testData.values().forEach((value) -> assertTrue(set.contains(value)));
} finally {
validateTXManager(disableSetOpToStartJTA, isAccessor);
if (!disableSetOpToStartJTA && !isAccessor) {
@@ -218,7 +218,7 @@ public class PRSetOperationJTADUnitTest extends JUnit4CacheTestCase {
assertTrue(testData.values().contains(entry.getValue()));
assertTrue(testData.keySet().contains(entry.getKey()));
});
- testData.entrySet().forEach((entry) -> set.contains(entry));
+ testData.entrySet().forEach((entry) -> assertTrue(set.contains(entry)));
} finally {
validateTXManager(disableSetOpToStartJTA, isAccessor);
if (!disableSetOpToStartJTA && !isAccessor) {
diff --git a/geode-core/src/test/java/org/apache/geode/internal/jta/SetOperationJTAJUnitTest.java b/geode-core/src/test/java/org/apache/geode/internal/jta/SetOperationJTAJUnitTest.java
index f6f7b71..4a295b2 100644
--- a/geode-core/src/test/java/org/apache/geode/internal/jta/SetOperationJTAJUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/internal/jta/SetOperationJTAJUnitTest.java
@@ -95,7 +95,7 @@ public class SetOperationJTAJUnitTest {
userTX.begin();
Collection<Long> set = region.keySet();
set.forEach((key) -> assertTrue(testData.keySet().contains(key)));
- testData.keySet().forEach((key) -> set.contains(key));
+ testData.keySet().forEach((key) -> assertTrue(set.contains(key)));
} finally {
validateTXManager(disableSetOpToStartJTA);
if (!disableSetOpToStartJTA) {
@@ -136,7 +136,7 @@ public class SetOperationJTAJUnitTest {
assertTrue(testData.values().contains(entry.getValue()));
assertTrue(testData.keySet().contains(entry.getKey()));
});
- testData.entrySet().forEach((entry) -> set.contains(entry));
+ testData.entrySet().forEach((entry) -> assertTrue(set.contains(entry)));
} finally {
validateTXManager(disableSetOpToStartJTA);
if (!disableSetOpToStartJTA) {
--
To stop receiving notification emails like this one, please contact
eshu11@apache.org.