You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/15 12:24:32 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3911: feat(ci): automatic make generate
squakez opened a new pull request, #3911:
URL: https://github.com/apache/camel-k/pull/3911
<!-- Description -->
With this PR we let the github actions to run every night a `make generate` and have it therefore a fresh version of the autogenerated resources. Additionally we have now the Changelog updated in all release branches as well. The new `automatic-updates` task can be appendend with any further task if required eventually.
Closes #3868
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
feat(ci): automatic make generate
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3911: feat(ci): automatic make generate
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3911:
URL: https://github.com/apache/camel-k/pull/3911#discussion_r1050705266
##########
.gitignore:
##########
@@ -168,3 +168,4 @@ config/**/*.gen.yaml
config/**/*.gen.json
*-installer*
+pkg/resources/resources.go
Review Comment:
I've made the change in ae815ddc01d98f4660c5d099f3f11ace3f346c9b, however, since then, the `validate` is failing. Maybe it required the presence of such a resource to be executed correctly. I'll revert the change to see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3911: feat(ci): automatic make generate
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3911:
URL: https://github.com/apache/camel-k/pull/3911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3911: feat(ci): automatic make generate
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3911:
URL: https://github.com/apache/camel-k/pull/3911#issuecomment-1353112621
:crossed_fingers: for tonight...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3911: feat(ci): automatic make generate
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3911:
URL: https://github.com/apache/camel-k/pull/3911#discussion_r1050415590
##########
.gitignore:
##########
@@ -168,3 +168,4 @@ config/**/*.gen.yaml
config/**/*.gen.json
*-installer*
+pkg/resources/resources.go
Review Comment:
@squakez
Btw, simply adding this to `.gitignore` doesn't ignore future changes to this file. To completely eliminate it from repo, we need to remove it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3911: feat(ci): automatic make generate
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3911:
URL: https://github.com/apache/camel-k/pull/3911#discussion_r1050415590
##########
.gitignore:
##########
@@ -168,3 +168,4 @@ config/**/*.gen.yaml
config/**/*.gen.json
*-installer*
+pkg/resources/resources.go
Review Comment:
@squakez
Btw, simply adding this to `.gitignore` doesn't ignore future changes to this file. To completely eliminate it from repo, we need to `git rm pkg/resources/resources.go` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3911: feat(ci): automatic make generate
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3911:
URL: https://github.com/apache/camel-k/pull/3911#discussion_r1050509454
##########
.gitignore:
##########
@@ -168,3 +168,4 @@ config/**/*.gen.yaml
config/**/*.gen.json
*-installer*
+pkg/resources/resources.go
Review Comment:
True. I will fix it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3911: feat(ci): automatic make generate
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3911:
URL: https://github.com/apache/camel-k/pull/3911#discussion_r1050718494
##########
.gitignore:
##########
@@ -168,3 +168,4 @@ config/**/*.gen.yaml
config/**/*.gen.json
*-installer*
+pkg/resources/resources.go
Review Comment:
I confirm, the commit in https://github.com/apache/camel-k/pull/3920 will fix that. It seems it is required, so, I will work to regenerate that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org