You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "becketqin (via GitHub)" <gi...@apache.org> on 2025/02/20 18:35:09 UTC
[PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
becketqin opened a new pull request, #26188:
URL: https://github.com/apache/flink/pull/26188
## What is the purpose of the change
There is a flaky unit test `SplitFetcherManagerTest.testCloseBlockingWaitingForFetcherShutdown()` in #25569 . This PR fixes that.
## Brief change log
Fix the flaky unit test.
## Verifying this change
Ran the unit test locally for over 100K times and there was no failure observed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26188:
URL: https://github.com/apache/flink/pull/26188#discussion_r1965897742
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -70,7 +70,7 @@ void testCloseFetcherWithException() throws Exception {
reader.setCloseWithException();
SplitFetcherManager<Object, TestingSourceSplit> fetcherManager =
createFetcher("test-split", reader, new Configuration());
- fetcherManager.close(1000L);
+ fetcherManager.close(30000L);
Review Comment:
I am curious does this add 29 seconds to the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "becketqin (via GitHub)" <gi...@apache.org>.
becketqin closed pull request #26188: [FLINK-36585][hotfix] Fix the flaky unit test.
URL: https://github.com/apache/flink/pull/26188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26188:
URL: https://github.com/apache/flink/pull/26188#issuecomment-2672402919
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74715ae694980fda5e4aee05072fb94ccc9af67a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74715ae694980fda5e4aee05072fb94ccc9af67a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74715ae694980fda5e4aee05072fb94ccc9af67a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "becketqin (via GitHub)" <gi...@apache.org>.
becketqin commented on PR #26188:
URL: https://github.com/apache/flink/pull/26188#issuecomment-2675085755
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26188:
URL: https://github.com/apache/flink/pull/26188#discussion_r1965897742
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -70,7 +70,7 @@ void testCloseFetcherWithException() throws Exception {
reader.setCloseWithException();
SplitFetcherManager<Object, TestingSourceSplit> fetcherManager =
createFetcher("test-split", reader, new Configuration());
- fetcherManager.close(1000L);
+ fetcherManager.close(30000L);
Review Comment:
I am curious could this add up to 29 seconds to the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #26188:
URL: https://github.com/apache/flink/pull/26188#issuecomment-2677551598
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #26188:
URL: https://github.com/apache/flink/pull/26188#issuecomment-2677825085
@becketqin thanks for looking into it
however based on ci it is still with the issue it is aiming to fix
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=66178&view=logs&j=e038c926-3157-5651-af43-716a7327eedc&t=4ae2386b-3221-5f3b-3cfb-589c6099d869&l=10960
Moreover the issue seems to be a blocker since I don't see any successful ci for master after it was merged...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "becketqin (via GitHub)" <gi...@apache.org>.
becketqin commented on PR #26188:
URL: https://github.com/apache/flink/pull/26188#issuecomment-2679239088
It looks like the CI tests of this PR is somehow no longer triggered. I'll close this PR and create a separate one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36585][hotfix] Fix the flaky unit test. [flink]
Posted by "becketqin (via GitHub)" <gi...@apache.org>.
becketqin commented on code in PR #26188:
URL: https://github.com/apache/flink/pull/26188#discussion_r1965966467
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -70,7 +70,7 @@ void testCloseFetcherWithException() throws Exception {
reader.setCloseWithException();
SplitFetcherManager<Object, TestingSourceSplit> fetcherManager =
createFetcher("test-split", reader, new Configuration());
- fetcherManager.close(1000L);
+ fetcherManager.close(30000L);
Review Comment:
No, it won't. Normally the close will return fairly quick (a few milliseconds). The additional timeout is just to avoid occasional failures due to slow machines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org