You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/01 08:03:28 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5057: Create fcd folder on local storage in VMware vSphere

sureshanaparti commented on a change in pull request #5057:
URL: https://github.com/apache/cloudstack/pull/5057#discussion_r642873964



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
##########
@@ -379,6 +381,7 @@ public static String getLegacyDatastorePathFromVmdkFileName(DatastoreMO dsMo, St
 
     //This method call is for the volumes to be created or can also be for volumes already exists
     public static String getDatastorePathBaseFolderFromVmdkFileName(DatastoreMO dsMo, String vmdkFileName) throws Exception {
+        HypervisorHostHelper.createBaseFolderInDatastore(dsMo, dsMo.getDataCenterMor());
         return String.format("[%s] %s/%s", dsMo.getName(), HypervisorHostHelper.VSPHERE_DATASTORE_BASE_FOLDER, vmdkFileName);

Review comment:
       @harikrishna-patnala changes LGTM, didn't test. Hope all the datastores are covered, and 'fcd' folder is created. Please run the smoke tests and check if there are any issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org