[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #5540: Add necessary features to optimizer

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #5540:
URL: https://github.com/apache/arrow-datafusion/pull/5540#discussion_r1131861166


##########
datafusion/core/Cargo.toml:
##########
@@ -41,21 +41,21 @@ path = "src/lib.rs"
 # Used to enable the avro format
 avro = ["apache-avro", "num-traits", "datafusion-common/avro"]
 compression = ["xz2", "bzip2", "flate2", "zstd", "async-compression"]
-crypto_expressions = ["datafusion-physical-expr/crypto_expressions"]
+crypto_expressions = ["datafusion-physical-expr/crypto_expressions", "datafusion-optimizer/crypto_expressions"]
 default = ["crypto_expressions", "regex_expressions", "unicode_expressions", "compression"]
 # Enables support for non-scalar, binary operations on dictionaries
 # Note: this results in significant additional codegen
-dictionary_expressions = ["datafusion-physical-expr/dictionary_expressions"]
+dictionary_expressions = ["datafusion-physical-expr/dictionary_expressions", "datafusion-optimizer/dictionary_expressions"]
 # Used for testing ONLY: causes all values to hash to the same value (test for collisions)
 force_hash_collisions = []
 # Used to enable JIT code generation
 jit = ["datafusion-jit", "datafusion-row/jit"]
 pyarrow = ["datafusion-common/pyarrow"]
-regex_expressions = ["datafusion-physical-expr/regex_expressions"]
+regex_expressions = ["datafusion-physical-expr/regex_expressions", "datafusion-optimizer/regex_expressions"]
 # Used to enable scheduler
 scheduler = ["rayon"]
 simd = ["arrow/simd"]
-unicode_expressions = ["datafusion-physical-expr/regex_expressions", "datafusion-sql/unicode_expressions"]

Review Comment:
   This was a bug (typo?) actually.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org