You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/16 16:45:00 UTC
[jira] [Commented] (METRON-1672) Add metron-alerts's UI unit tests
to travis build process
[ https://issues.apache.org/jira/browse/METRON-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545466#comment-16545466 ]
ASF GitHub Bot commented on METRON-1672:
----------------------------------------
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/1106
METRON-1672: Add metron-alerts's UI unit tests to travis build process
## Contributor Comments
Couple things happen here:
- Added a mvn test goal for the metron-alert UI tests
- Made the tests use Chrome headless in order to actually have them run properly in Travis. Also added the Chrome add-on in Travis for this.
- Updated node/npm versions to fix some issues with running the tests. Matched the version to https://github.com/apache/metron/pull/1096
- The build started going over time, so I resurrected the build matrix from https://github.com/apache/metron/pull/854. I left out the Maven wrapper stuff. Given that Apache's been pretty good with Travis and other projects use this capability, I'm in favor of using it now that we're cramming even more in.
### Build Matrix
As stated, a build matrix was added to the Travis build. It breaks things into 4 sections the same as the PR it's based on.
1. Unit Tests
2. Integration Tests
3. UI tests
4. License validation
Javadoc is skipped, because it's broken (sigh). I have the fixes in a branch, and I'd like to turn it on as follow-on.
### Testing
Make sure that `mvn test` works from metron-interface/metron-alerts. It should not spin up an actual Chrome window and should be headless.
If you choose to push into Travis, you should see something the following in the output. This can be seen at https://travis-ci.org/justinleet/metron/jobs/404500911. The overall build matrix job can be seen at https://travis-ci.org/justinleet/metron/builds/404500908.
```
[INFO] > metron-alerts@0.5.1 test /home/travis/build/justinleet/metron/metron-interface/metron-alerts
[INFO] > karma start --single-run --browsers ChromeHeadless karma.conf.js
[INFO]
[INFO] 16 07 2018 16:01:20.477:INFO [karma]: Karma v1.4.1 server started at http://0.0.0.0:9876/
[INFO] 16 07 2018 16:01:20.480:INFO [launcher]: Launching browser ChromeHeadless with unlimited concurrency
[INFO] 16 07 2018 16:01:20.492:INFO [launcher]: Starting browser Chrome
[INFO] 16 07 2018 16:01:44.456:INFO [HeadlessChrome 0.0.0 (Linux 0.0.0)]: Connected on socket Ts9_772t05A32OhrAAAA with id 78239511
[INFO] HeadlessChrome 0.0.0 (Linux 0.0.0): Executed 0 of 23 SUCCESS (0 secs / 0 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 1 of 23 SUCCESS (0 secs / 0.205 secs)
[INFO] 16 07 2018 16:01:48.411:WARN [web-server]: 404: /api/v1/global/config
[INFO] 16 07 2018 16:01:48.418:WARN [web-server]: 404: /api/v1/global/config
[INFO] e 0.0.0 (Linux 0.0.0): Executed 2 of 23 SUCCESS (0 secs / 0.41 secs)
[INFO] 16 07 2018 16:01:48.611:WARN [web-server]: 404: /api/v1/global/config
[INFO] e 0.0.0 (Linux 0.0.0): Executed 3 of 23 SUCCESS (0 secs / 0.581 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 4 of 23 SUCCESS (0 secs / 0.738 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 5 of 23 SUCCESS (0 secs / 0.783 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 6 of 23 SUCCESS (0 secs / 0.853 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 7 of 23 SUCCESS (0 secs / 0.884 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 8 of 23 SUCCESS (0 secs / 0.911 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 9 of 23 SUCCESS (0 secs / 0.936 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 10 of 23 SUCCESS (0 secs / 0.952 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 11 of 23 SUCCESS (0 secs / 1.003 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 12 of 23 SUCCESS (0 secs / 1.039 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 13 of 23 SUCCESS (0 secs / 1.04 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 14 of 23 SUCCESS (0 secs / 1.04 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 15 of 23 SUCCESS (0 secs / 1.073 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 16 of 23 SUCCESS (0 secs / 1.074 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 17 of 23 SUCCESS (0 secs / 1.075 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 18 of 23 SUCCESS (0 secs / 1.1 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 19 of 23 SUCCESS (0 secs / 1.101 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 20 of 23 SUCCESS (0 secs / 1.101 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 21 of 23 SUCCESS (0 secs / 1.101 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 22 of 23 SUCCESS (0 secs / 1.126 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 23 of 23 SUCCESS (0 secs / 1.214 secs)
[INFO] e 0.0.0 (Linux 0.0.0): Executed 23 of 23 SUCCESS (1.249 secs / 1.214 secs)
```
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron mvnAlertsUiTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1106
----
commit 09a9654866bb817872095be7e9bbd271e471d5dd
Author: justinjleet <ju...@...>
Date: 2018-07-12T16:29:08Z
Updating node version, adding test to lifecyle, and passing through skipTests
commit 2c586fed0bea8e86f4df9d0ddaa3c6eb509fcce0
Author: justinjleet <ju...@...>
Date: 2018-07-12T16:51:32Z
conforming to metron-config naming and adding to travis
commit a2c267e122ceab629716d4f685d2dd44abdbffb3
Author: justinjleet <ju...@...>
Date: 2018-07-12T17:42:42Z
don't need to do anything to make skipTests work
commit fca4a8f4565ae8edfc46bdb00c694595b6bb6561
Author: justinjleet <ju...@...>
Date: 2018-07-16T13:46:21Z
Migrating to headless chrome tests
commit 67868b276ed35f0e2e78ad64861681251612cd35
Author: justinjleet <ju...@...>
Date: 2018-07-16T14:25:47Z
Trying build matrix
commit 23dce53fe223c28c4ef9c2c808f6fe7bafa7ca6c
Author: justinjleet <ju...@...>
Date: 2018-07-16T15:06:15Z
Fixing utils path
----
> Add metron-alerts's UI unit tests to travis build process
> ---------------------------------------------------------
>
> Key: METRON-1672
> URL: https://issues.apache.org/jira/browse/METRON-1672
> Project: Metron
> Issue Type: Bug
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Major
>
> The tests for metron-alerts don't run as part of Travis. They should run as part of Travis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)