You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Tim Armstrong (JIRA)" <ji...@apache.org> on 2017/06/16 17:17:00 UTC
[jira] [Resolved] (IMPALA-4483) run-backend-tests.sh does not work
with ninja
[ https://issues.apache.org/jira/browse/IMPALA-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong resolved IMPALA-4483.
-----------------------------------
Resolution: Fixed
Assignee: Jim Apple
Fix Version/s: Impala 2.10.0
Fixed by this commit:
/request-pool-service.cc: StatsMetric<double>::CreateAndRegister(metrics, RESOLVE_POOL_METRIC_NAME);
be/src/scheduling/request-pool-service.h: StatsMetric<double>* resolve_pool_ms_metric_;
be/src/statestore/statestore-subscriber.cc: topic_update_interval_metric_ = StatsMetric<double>::CreateAndRegister(metrics,
be/src/statestore/statestore-subscriber.cc: topic_update_duration_metric_ = StatsMetric<double>::CreateAndRegister(metrics,
be/src/statestore/statestore-subscriber.cc: heartbeat_interval_metric_ = StatsMetric<double>::CreateAndRegister(metrics,
be/src/statestore/statestore-subscriber.cc: cb->processing_time_metric = StatsMetric<double>::CreateAndRegister(metrics_,
be/src/statestore/statestore-subscriber.h: StatsMetric<double>* processing_time_metric;
be/src/statestore/statestore-subscriber.h: StatsMetric<double>* topic_update_interval_metric_;
be/src/statestore/statestore-subscriber.h: StatsMetric<double>* topic_update_duration_metric_;
be/src/statestore/statestore-subscriber.h: StatsMetric<double>* heartbeat_interval_metric_;
be/src/statestore/statestore.cc: StatsMetric<double>::CreateAndRegister(metrics, STATESTORE_UPDATE_DURATION);
be/src/statestore/statestore.cc: StatsMetric<double>::CreateAndRegister(metrics, STATESTORE_HEARTBEAT_DURATION);
be/src/statestore/statestore.h: StatsMetric<double>* topic_update_duration_metric_;
be/src/statestore/statestore.h: StatsMetric<double>* heartbeat_duration_metric_;
be/src/util/collection-metrics.h:/// Enum to define which statistic types are available in the StatsMetric
be/src/util/collection-metrics.h:class StatsMetric : public Metric {
be/src/util/collection-metrics.h: static StatsMetric* CreateAndRegister(MetricGroup* metrics, const std::string& key,
be/src/util/collection-metrics.h: return metrics->RegisterMetric(new StatsMetric(MetricDefs::Get(key, arg)));
be/src/util/collection-metrics.h: StatsMetric(const TMetricDef& def) : Metric(def), unit_(def.units) {
be/src/util/impalad-metrics.cc:StatsMetric<uint64_t, StatsType::MEAN>*
be/src/util/impalad-metrics.cc: StatsMetric<uint64_t, StatsType::MEAN>::CreateAndRegister(m,
be/src/util/impalad-metrics.h: static StatsMetric<uint64_t, StatsType::MEAN>* IO_MGR_CACHED_FILE_HANDLES_HIT_RATIO;
be/src/util/metrics-test.cc:TEST_F(MetricsTest, StatsMetrics) {
be/src/util/metrics-test.cc: MetricGroup metrics("StatsMetrics");
be/src/util/metrics-test.cc: StatsMetric<double>* stats_metric = StatsMetric<double>::CreateAndRegister(&metrics,
be/src/util/metrics-test.cc: StatsMetric<double>* stats_metric_with_units =
be/src/util/metrics-test.cc: StatsMetric<double>::CreateAndRegister(&metrics, "stats_units");
be/src/util/metrics-test.cc:TEST_F(MetricsTest, StatsMetricsSingle) {
be/src/util/metrics-test.cc: MetricGroup metrics("StatsMetrics");
be/src/util/metrics-test.cc: StatsMetric<int, StatsType::MAX | StatsType::MEAN>*
be/src/util/metrics-test.cc: StatsMetric<int, StatsType::MAX | StatsType::MEAN>::CreateAndRegister(&metrics,
be/src/util/metrics-test.cc:TEST_F(MetricsTest, StatsMetricsJson) {
be/src/util/metrics-test.cc: MetricGroup metrics("StatsMetrics");
be/src/util/metrics-test.cc: StatsMetric<double>* metric = StatsMetric<double>::CreateAndRegister(&metrics,
tarmstrong@tarmstrong-box:~/Impala/incubator-impala$ .,/^C
tarmstrong@tarmstrong-box:~/Impala/incubator-impala$ vim bin/run-backend-tests.sh
tarmstrong@tarmstrong-box:~/Impala/incubator-impala$ git log bin/run-backend-tests.sh
commit 514e04ea4ff3b7dc4225144b869616f2f92e4573
Author: Jim Apple <jb...@apache.org>
Date: Sat May 20 16:22:01 2017 -0700
Ninja support: use MAKE_CMD in run-backend-tests.sh when possible
Without this, buildall.sh -ninja fails to run the backend tests or
runs them with the Makefiles that were created when buildall.sh was
last run without the -ninja flag.
Change-Id: Idb920dd4b08d8ef5fbc0bf1ea1b424a0c544e1db
Reviewed-on: http://gerrit.cloudera.org:8080/6942
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
> run-backend-tests.sh does not work with ninja
> ---------------------------------------------
>
> Key: IMPALA-4483
> URL: https://issues.apache.org/jira/browse/IMPALA-4483
> Project: IMPALA
> Issue Type: Bug
> Components: Infrastructure
> Affects Versions: Impala 2.8.0
> Reporter: Jim Apple
> Assignee: Jim Apple
> Priority: Minor
> Labels: newbie
> Fix For: Impala 2.10.0
>
>
> run-backend-tests.hs runs with make, not $MAKE_CMD like other files in bin. If there is no makefile because ninja was used for the build, then this script cannot run. Switching it to use ninja, however, isn't a complete solution, because ninja is so spartan with its output that it provides much less feedback.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)