You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Yosuke Shiro (JIRA)" <ji...@apache.org> on 2019/01/31 15:20:00 UTC
[jira] [Comment Edited] (ARROW-4235) [GLib] Use "column_builder" in
GArrowRecordBatchBuilder
[ https://issues.apache.org/jira/browse/ARROW-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757349#comment-16757349 ]
Yosuke Shiro edited comment on ARROW-4235 at 1/31/19 3:19 PM:
--------------------------------------------------------------
[~kou]
I thought about the name again in [https://github.com/apache/arrow/pull/3360#discussion_r246668833].
How about `array_builders`? Because `get_field(i)` return `array_builder`.
So I think it is better to change the followings in this ticket.
・[GLib] Change garrow_record_batch_builder_get_field() to garrow_record_batch_builder_get_array_builders() in GArrowRecordBatchBuilder
・[Ruby] Change column_builders to array_builders in RecordBatchBuilder
was (Author: shiro615):
[~kou]
I thought about the name again in https://github.com/apache/arrow/pull/3360#discussion_r246668833.
How about `array_builders`? Because `get_field(i)` return `array_builder`.
So I think it is better to change the followings in this ticket.
- [GLib] Change garrow_record_batch_builder_get_field() to garrow_record_batch_builder_get_array_builders() in GArrowRecordBatchBuilder
- [Ruby] Change column_builders to array_builders in RecordBatchBuilder
> [GLib] Use "column_builder" in GArrowRecordBatchBuilder
> -------------------------------------------------------
>
> Key: ARROW-4235
> URL: https://issues.apache.org/jira/browse/ARROW-4235
> Project: Apache Arrow
> Issue Type: Improvement
> Components: GLib
> Reporter: Kouhei Sutou
> Assignee: Yosuke Shiro
> Priority: Major
> Fix For: 0.13.0
>
>
> https://github.com/apache/arrow/pull/3360#discussion_r246668833
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)