You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/20 12:29:37 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request, #16703: [fix][test] Fix testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription
RobertIndie opened a new pull request, #16703:
URL: https://github.com/apache/pulsar/pull/16703
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #16515
### Motivation
The receiver queue size is too small. This causes the entry filter to trigger message redelivery more frequently. However, there will be a default interval of 1 second when delivering messages. This tends to make the whole test take too long, leading to the timeout exception.
### Modifications
* Increase the receiver queue size
* Fix some problems in the test
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie merged pull request #16703: [fix][test] Fix testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription
Posted by GitBox <gi...@apache.org>.
RobertIndie merged PR #16703:
URL: https://github.com/apache/pulsar/pull/16703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #16703: [fix][test] Fix testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on PR #16703:
URL: https://github.com/apache/pulsar/pull/16703#issuecomment-1192110517
> initially I set the size to 5 because the test may take to long, because we had a fixed delay of 1000 in case of RESCHEDULE
>
> now it is configurable with `dispatcherEntryFilterRescheduledMessageDelay`, reducing it to 100ms may probably help to make the test run faster
Thanks. That's another approach. But I think the current approach s enough to reduce the time spent on testing.
> 1. The message will be redelivered multiple times, which can also make this test to be flaky
This PR greatly reduces the number of messages re-deliveries. And there is a 1-minute wait time, which I think is enough.
> 2. Is `Key_Shared` subscription supported for this feature? AFAICS, `Key_Shared` consumer may introduce endless redeliver
That's another topic. I will take a look later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wuxuanqicn commented on pull request #16703: [fix][test] Fix testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription
Posted by GitBox <gi...@apache.org>.
wuxuanqicn commented on PR #16703:
URL: https://github.com/apache/pulsar/pull/16703#issuecomment-1190970777
1. The message will be redelivered multiple times, which can also make this test to be flaky
2. Is `Key_Shared` subscription supported for this feature? AFAICS, `Key_Shared` consumer may introduce endless redeliver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16703: [fix][test] Fix testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16703:
URL: https://github.com/apache/pulsar/pull/16703#issuecomment-1190241935
@RobertIndie Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #16703: [fix][test] Fix testEntryFilterRescheduleMessageDependingOnConsumerSharedSubscription
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #16703:
URL: https://github.com/apache/pulsar/pull/16703#issuecomment-1190335368
initially I set the size to 5 because the test may take to long, because we had a fixed delay of 1000 in case of RESCHEDULE
now it is configurable with `dispatcherEntryFilterRescheduledMessageDelay`, reducing it to 100ms may probably help to make the test run faster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org