You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/18 15:40:34 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #11635: Fix incorrect typing and move config args out of extra connection config to operator args
ephraimbuddy opened a new pull request #11635:
URL: https://github.com/apache/airflow/pull/11635
The PR #11359 made` vm_publisher`, `vm_sku` and `sku_starts_with` a required argument in AzureBatchOperator.
It's possible to run batch job using cloud service configuration or virtual machine configuration.
Both are mutually exclusive, making `vm_publisher` etc, a required argument will not allow anyone to run batch job using cloud service configuration.
Also, I moved service configuration argument from connection extra to operator. When I originally wrote this hook, I had very little experience of airflow and passed these arguments through the connection extra parameter. Now, I think it's not Ok, hence asking to correct it through this PR.
cc @turbaszek @mik-laj
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11635: Fix incorrect typing and move config args out of extra connection config to operator args
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11635:
URL: https://github.com/apache/airflow/pull/11635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org