You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/06/05 20:40:00 UTC
Review Request 67457: Windows: Ported docker_containerizer_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342
Repository: mesos
Description
-------
With some Docker bug fixes and the IOCP backend, the remaining docker
have been ported. The only remaining Docker tests that aren't ported
are either due to limitations on Windows Containers or unimplemented
features in Mesos (Persistent volume and hooks).
Diffs
-----
src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
Diff: https://reviews.apache.org/r/67457/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204347
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67384', '67385', '67386', '67387', '67388', '67389', '67390', '67391', '67392', '67393', '67455', '67456', '67457']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67457
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67457/logs/mesos-tests-stdout.log):
```
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (963 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (746 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[ OK ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1541 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (969 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (973 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1422 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[ OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (734 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[ OK ] DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5601 ms)
[ RUN ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[ OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5811 ms)
[----------] 24 tests from DockerContainerizerTest (105814 ms total)
[----------] 1 test from HungDockerTest
[ RUN ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull
d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000FED5AFBF60.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5189): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000000FED5AFC1C0.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000002EB98C0B8D0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000002EB991A0AD8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never is. Its address is @000002EB99D13190.
ERROR: 5 leaked mock objects found at program exit.
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67457/logs/mesos-tests-stderr.log):
```
I0605 22:01:23.478771 24908 authenticatee.cpp:299] Authentication success
I0605 22:01:23.479773 25040 master.cpp:9633] Successfully authenticated principal 'test-principal' at scheduler-d03482ef-f31f-4804-9c7b-5332fe1fd85e@192.10.1.6:54921
I0605 22:01:23.479773 25432 sched.cpp:501] Successfully authenticated with master master@192.10.1.6:54921
I0605 22:01:23.480772 6620 master.cpp:2890] Received SUBSCRIBE call for framework 'default' at scheduler-d03482ef-f31f-4804-9c7b-5332fe1fd85e@192.10.1.6:54921
I0605 22:01:23.480772 6620 master.cpp:2197] Authorizing framework principal 'test-principal' to receive offers for roles '{ * }'
I0605 22:01:23.481794 23824 master.cpp:2971] Subscribing framework default with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0605 22:01:23.482769 23824 master.cpp:9824] Adding framework 7eefd355-ca3a-46bc-9d8f-f6bf38e8e1b9-0000 (default) at scheduler-d03482ef-f31f-4804-9c7b-5332fe1fd85e@192.10.1.6:54921 with roles { } suppressed
I0605 22:01:23.484766 4972 sched.cpp:749] Framework registered with 7eefd355-ca3a-46bc-9d8f-f6bf38e8e1b9-0000
I0605 22:01:23.484766 29664 hierarchical.cpp:297] Added framework 7eefd355-ca3a-46bc-9d8f-f6bf38e8e1b9-0000
E0605 22:01:23.570777 25584 slave.cpp:7289] EXIT with status 1: Failed to perform recovery: Collect failed: Failed to run 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat -H npipe:////./pipe/docker_engine ps -a': exited with status 1; stderr=''C:\Program' is not recognized as an internal or external command,
operable program or batch file.
'
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.
To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\kEBMxi\meta\slaves\latest
This ensures that the agent does not recover old live executors.
If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
- Mesos Reviewbot Windows
On June 5, 2018, 8:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 8:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204351
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67384, 67385, 67386, 67387, 67388, 67389, 67390, 67391, 67392, 67393, 67455, 67456, 67457]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 5, 2018, 1:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review205174
-----------------------------------------------------------
PASS: Mesos patch 67457 was successfully built and tested.
Reviews applied: `['67384', '67385', '67386', '67387', '67388', '67389', '67685', '67390', '67391', '67392', '67393', '67456', '67457']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67457
- Mesos Reviewbot Windows
On June 5, 2018, 8:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 8:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review205262
-----------------------------------------------------------
PASS: Mesos patch 67457 was successfully built and tested.
Reviews applied: `['67384', '67385', '67386', '67387', '67388', '67389', '67685', '67390', '67391', '67392', '67393', '67456', '67457']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67457
- Mesos Reviewbot Windows
On June 5, 2018, 1:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review205210
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67384, 67385, 67386, 67387, 67388, 67389, 67685, 67390, 67391, 67392, 67393, 67456, 67457]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 5, 2018, 4:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 4:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review205263
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67384, 67385, 67386, 67387, 67388, 67389, 67685, 67390, 67391, 67392, 67393, 67456, 67457]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 5, 2018, 8:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 8:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204619
-----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 127-160 (original), 136-180 (patched)
<https://reviews.apache.org/r/67457/#comment287203>
Ah! Found it. The changes besides the increased durations slipped right past me.
- Andrew Schwartzmeyer
On June 5, 2018, 1:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On June 8, 2018, 4:12 p.m., Andrew Schwartzmeyer wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Line 300 (original), 339 (patched)
> > <https://reviews.apache.org/r/67457/diff/1/?file=2035342#file2035342line339>
> >
> > What changed here to need another argument?
>
> Akash Gupta wrote:
> It's just an optimization. The `exists()` function works like this:
> ```
> bool exists(docker, id, desiredState) {
> while(time < timeout) {
> inspectResult = docker->inspect()
>
> if (inspectResult.success()) {
> if (desiredState == EXISTS) { return true; }
> if (desiredState == RUNNING && inspectResult.containerIsRunning()) { return true; }
> }
>
> wait(SOME_TIME);
> updateTime(&time, SOME_TIME);
> }
> return false;
> }
> ```
>
> Basically it retries an unsuccessfult result until you get a timeout. But, a lot of the tests add a `ASSERT_FALSE(docker, container, ContainerState::{RUNNING,EXISTS}, false)` at the end to check if the container is *not* running or existing. Since false is only returned after `timeout`, each test would spend `timeout` seconds just doing the above loop. This was especially bad on Windows, since the timeouts need to be longer, so each test was waiting like 15+ seconds just for `exists()` to return false. So I just added another variable and controls the retry behavior, so that the tests don't waste so much time.
Gotcha! I like it; good improvement.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204507
-----------------------------------------------------------
On June 5, 2018, 1:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 67457: Windows: Ported
docker_containerizer_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67457/#review204507
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/docker_containerizer_tests.cpp
Line 300 (original), 339 (patched)
<https://reviews.apache.org/r/67457/#comment287027>
What changed here to need another argument?
src/tests/containerizer/docker_containerizer_tests.cpp
Lines 5107-5120 (patched)
<https://reviews.apache.org/r/67457/#comment287028>
I am so sorry.
- Andrew Schwartzmeyer
On June 5, 2018, 1:40 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67457/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 1:40 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With some Docker bug fixes and the IOCP backend, the remaining docker
> have been ported. The only remaining Docker tests that aren't ported
> are either due to limitations on Windows Containers or unimplemented
> features in Mesos (Persistent volume and hooks).
>
>
> Diffs
> -----
>
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
> src/tests/containerizer/docker_containerizer_tests.cpp 194308bf9d09a3562e683c49e0da4c9a6463d66e
>
>
> Diff: https://reviews.apache.org/r/67457/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>