You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/05 04:54:47 UTC

[GitHub] [spark] viirya opened a new pull request #24525: [SPARK-27633][SQL] Remove redundant aliases in NestedColumnAliasing

viirya opened a new pull request #24525: [SPARK-27633][SQL] Remove redundant aliases in NestedColumnAliasing
URL: https://github.com/apache/spark/pull/24525
 
 
   ## What changes were proposed in this pull request?
   
   In NestedColumnAliasing rule, we create aliases for nested field access in project list. We considered that top level parent field and nested fields under it were both accessed. In the case, we don't create the aliases because they are redundant.
   
   There is another case, where a nested parent field and nested fields under it were both accessed, which we don't consider now. We don't need to create aliases in this case too.
   
   ## How was this patch tested?
   
   Added test.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org