[GitHub] [incubator-superset] hughhhh commented on a change in pull request #11463: feat: create base class for export commands

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #11463:
URL: https://github.com/apache/incubator-superset/pull/11463#discussion_r513888943



##########
File path: superset/importexport/commands/base.py
##########
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+from datetime import datetime
+from datetime import timezone
+from typing import Iterator, List, Tuple
+
+import yaml
+from flask_appbuilder import Model
+
+from superset.commands.base import BaseCommand
+from superset.commands.exceptions import CommandException
+from superset.dao.base import BaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION
+
+
+class ExportModelsCommand(BaseCommand):
+
+    dao = BaseDAO
+    not_found = CommandException
+
+    def __init__(self, model_ids: List[int]):

Review comment:
       ```suggestion
   	def __init__(self, model_ids: List[int]) -> None:
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org