[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5403: fixing template argument if not specify values

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #5403:
URL: https://github.com/apache/incubator-pinot/pull/5403#discussion_r426137350



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/GroovyTemplateUtils.java
##########
@@ -57,6 +57,9 @@ public static String renderTemplate(String template, Map<String, Object> newCont
   }
 
   public static Map<String, Object> getTemplateContext(List<String> values) {
+    if (values == null) {

Review comment:
       if `context` is an empty map, then `propertiesMap` won't change. This is just for NPE check.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org