[jira] [Commented] (ARROW-6190) [C++] Define and declare functions regardless of NDEBUG

["Omer Ozarslan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-6190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904070#comment-16904070 ] 

Omer Ozarslan commented on ARROW-6190:
--------------------------------------

Submitted PR on https://github.com/apache/arrow/pull/5049.

> [C++] Define and declare functions regardless of NDEBUG
> -------------------------------------------------------
>
>                 Key: ARROW-6190
>                 URL: https://issues.apache.org/jira/browse/ARROW-6190
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Omer Ozarslan
>            Priority: Minor
>
> NDEBUG is not shipped in linker flags, so I got a linker error with release build on FixedSizeBinaryBuilder::UnsafeAppend(util::string_view value) call, since it makes a call to CheckValueSize.
> This is somewhat a follow-up of ARROW-2313. I took the same path by removing NDEBUG ifdefs around CheckValueSize definition and declaration.
> I applied the same fix to CheckUTF8Initialized as well after grepping the source code for "#ifndef NDEBUG" and figured out it has the same issue.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)