You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/18 05:40:48 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #293: Make this
build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
yamt opened a new pull request #293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
URL: https://github.com/apache/incubator-nuttx/pull/293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #293: Make
this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
URL: https://github.com/apache/incubator-nuttx/pull/293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #293:
Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
URL: https://github.com/apache/incubator-nuttx/pull/293#issuecomment-587295968
> should this be added to every arm Make.defs variants?
But there isn't common Make.defs for all ARM, we have to add it to each of Make.defs. The code should work cross all ARM variant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #293: Make
this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
URL: https://github.com/apache/incubator-nuttx/pull/293#issuecomment-587295968
> should this be added to every arm Make.defs variants?
But there isn't common Make.defs for all ARM, we have to add it to each of Make.defs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #293: Make this build
with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
URL: https://github.com/apache/incubator-nuttx/pull/293#issuecomment-587288346
should this be added to every arm Make.defs variants?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #293:
Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
URL: https://github.com/apache/incubator-nuttx/pull/293#discussion_r381065923
##########
File path: arch/arm/src/tiva/Make.defs
##########
@@ -53,6 +53,7 @@ CMN_CSRCS += up_releasepending.c up_releasestack.c up_reprioritizertr.c
CMN_CSRCS += up_schedulesigaction.c up_sigdeliver.c up_stackframe.c
CMN_CSRCS += up_svcall.c up_trigger_irq.c up_unblocktask.c up_udelay.c
CMN_CSRCS += up_usestack.c up_vfork.c
+CMN_CSRCS += up_hostfs.c
Review comment:
it makes sense. i'll add the make conditional. and probably remove the guard in the C file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #293: Make this build with CONFIG_ARM_SEMIHOSTING_HOSTFS=y
URL: https://github.com/apache/incubator-nuttx/pull/293#discussion_r380687279
##########
File path: arch/arm/src/tiva/Make.defs
##########
@@ -53,6 +53,7 @@ CMN_CSRCS += up_releasepending.c up_releasestack.c up_reprioritizertr.c
CMN_CSRCS += up_schedulesigaction.c up_sigdeliver.c up_stackframe.c
CMN_CSRCS += up_svcall.c up_trigger_irq.c up_unblocktask.c up_udelay.c
CMN_CSRCS += up_usestack.c up_vfork.c
+CMN_CSRCS += up_hostfs.c
Review comment:
There is a check inside of up_hostfs.c, but it would speed compile times a tiny amount if this were enclosed in if ($(CONFIG_ARM_SEMIHOSTING_HOSTFS),y) so that the dependency is clearer and we don't wast the little bit of time compiling an empty file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services