You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "tomncooper (via GitHub)" <gi...@apache.org> on 2025/04/01 16:51:22 UTC
[PR] Add pre-commit git hook for common linting checks [flink]
tomncooper opened a new pull request, #26386:
URL: https://github.com/apache/flink/pull/26386
## What is the purpose of the change
There are several linting checks contained within the github actions [pre-compile workflow](https://github.com/apache/flink/blob/master/.github/workflows/template.pre-compile-checks.yml).
It would be useful to have these checks run as a pre-commit hook in git so that any linting issues are spotted before they are pushed remotely.
This PR contains an example pre-commit git hook script in the new `tools/git-hooks` directory with instructions on how to symlink the script to the developers local `.git/hooks` directory.
This hook is entirely optional and once added can be skipped with the `--no-verify` flag.
## Brief change log
- Add example pre-commit git hub script in the new `tools/git-hooks` directory.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add pre-commit git hook for common linting checks [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26386:
URL: https://github.com/apache/flink/pull/26386#issuecomment-2770002518
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8e5a97450862771d275f83063c4c2d15c4864224",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8e5a97450862771d275f83063c4c2d15c4864224",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e5a97450862771d275f83063c4c2d15c4864224 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37600] Add pre-commit git hook for common linting checks [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26386:
URL: https://github.com/apache/flink/pull/26386#issuecomment-3388455143
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37600] Add pre-commit git hook for common linting checks [flink]
Posted by "tomncooper (via GitHub)" <gi...@apache.org>.
tomncooper commented on PR #26386:
URL: https://github.com/apache/flink/pull/26386#issuecomment-3056551133
This would still be a useful feature for developers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37600] Add pre-commit git hook for common linting checks [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26386:
URL: https://github.com/apache/flink/pull/26386#issuecomment-3034683719
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37600] Add pre-commit git hook for common linting checks [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #26386:
URL: https://github.com/apache/flink/pull/26386#issuecomment-2778707270
As per this weeks [CHI meeting](https://cwiki.apache.org/confluence/x/Fwq9F) with @tomncooper, it would be good to decide what the server side implementation should be for checking pre commits, at the same time as proposing the client linting, so we can ensure that the checks are not duplicated and there is one golden version of checks.
The server side could drive the Git hooks using Git Actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37600] Add pre-commit git hook for common linting checks [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26386:
URL: https://github.com/apache/flink/pull/26386#issuecomment-3509642311
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37600] Add pre-commit git hook for common linting checks [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26386: [FLINK-37600] Add pre-commit git hook for common linting checks
URL: https://github.com/apache/flink/pull/26386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org